[gnome-system-tools] Fix libemap.a linking with --add-needed
- From: Milan Bouchet-Valat <milanbv src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-system-tools] Fix libemap.a linking with --add-needed
- Date: Thu, 6 Jan 2011 11:18:46 +0000 (UTC)
commit 8dd566d795a93418291c5a363e4480df1f893aaf
Author: Michael Bienia <geser ubuntu com>
Date: Thu Jan 6 12:10:57 2011 +0100
Fix libemap.a linking with --add-needed
When linking with the --add-needed option, ld doesn't find symbols
from -latk-1.0 because they are specified before libemap.a, while
libs containing functions used by an object are expected to appear
after it. This leads to this error when trying to resolve
atk_object_set_name(), which is used by libemap.a:
/usr/bin/ld: /usr/lib/libgtk-x11-2.0.so: undefined reference to symbol 'atk_object_set_name'
/usr/bin/ld: note: 'atk_object_set_name' is defined in DSO /usr/lib/libatk-1.0.so so try adding it to the linker command line
/usr/lib/libatk-1.0.so: could not read symbols: Invalid operation
This was uncovered by Ubuntu when switching their builds to --add-needed.
Change time_admin_DEPENDENCIES order for consistency.
src/time/Makefile.am | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/time/Makefile.am b/src/time/Makefile.am
index e9adaf4..aca9d77 100644
--- a/src/time/Makefile.am
+++ b/src/time/Makefile.am
@@ -15,8 +15,8 @@ INCLUDES += $(GST_TOOL_CFLAGS) $(DBUS_CFLAGS)
CLEANFILES = $(GST_TOOL_CLEANFILES)
EXTRA_DIST = $(GST_TOOL_EXTRA_DIST)
-time_admin_LDADD = $(GST_TOOL_LIBS) $(DBUS_LIBS) ./e-map/libemap.a
-time_admin_DEPENDENCIES = $(GST_TOOL_DEPENDENCIES) ./e-map/libemap.a
+time_admin_LDADD = ./e-map/libemap.a $(GST_TOOL_LIBS) $(DBUS_LIBS)
+time_admin_DEPENDENCIES = ./e-map/libemap.a $(GST_TOOL_DEPENDENCIES)
time_admin_SOURCES = \
time-tool.c time-tool.h \
tz.c tz.h \
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]