[tracker/gdbus-porting] miner-fs: Answer the earlier asked question
- From: Philip Van Hoof <pvanhoof src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [tracker/gdbus-porting] miner-fs: Answer the earlier asked question
 
- Date: Fri,  7 Jan 2011 10:39:14 +0000 (UTC)
 
commit 73ba4c35e275745def474d2eb755920e962c138b
Author: Philip Van Hoof <philip codeminded be>
Date:   Fri Jan 7 11:38:35 2011 +0100
    miner-fs: Answer the earlier asked question
 src/miners/fs/tracker-miner-files.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
---
diff --git a/src/miners/fs/tracker-miner-files.c b/src/miners/fs/tracker-miner-files.c
index 7b6e791..f5268bd 100644
--- a/src/miners/fs/tracker-miner-files.c
+++ b/src/miners/fs/tracker-miner-files.c
@@ -2035,9 +2035,7 @@ get_metadata_fast_async (GDBusConnection *connection,
 	                                                                        NULL)));
 	g_dbus_message_set_unix_fd_list (message, fd_list);
 
-	/* Note from Philip to reviewer:
-	 * I'm not sure if we have to close pipefd[1] here, or if the unref of
-	 * fd_list will do it. */
+	/* We need to close the fd as g_unix_fd_list_append duplicates the fd */
 
 	close (pipefd[1]);
 
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]