[gnumeric] In the conditional style dialog don't parse the espressions too often
- From: Andreas J. Guelzow <guelzow src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnumeric] In the conditional style dialog don't parse the espressions too often
- Date: Mon, 11 Jul 2011 22:01:06 +0000 (UTC)
commit c31ad5c81e5d7bf799e07c4bb7192f4c69662b98
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date: Mon Jul 11 15:58:46 2011 -0600
In the conditional style dialog don't parse the espressions too often
2011-07-11 Andreas J. Guelzow <aguelzow pyrshep ca>
* dialog-cell-format-cond.c (cb_c_fmt_dialog_chooser_entry_changed):
change signature
(c_fmt_dialog_init_editor_page): don't trigger parsing of the expression
entries on any change. This would cause problems with conversion into
strings.
src/dialogs/ChangeLog | 8 ++++++++
src/dialogs/dialog-cell-format-cond.c | 11 ++++++-----
2 files changed, 14 insertions(+), 5 deletions(-)
---
diff --git a/src/dialogs/ChangeLog b/src/dialogs/ChangeLog
index 74aa993..2cbd897 100644
--- a/src/dialogs/ChangeLog
+++ b/src/dialogs/ChangeLog
@@ -1,5 +1,13 @@
2011-07-11 Andreas J. Guelzow <aguelzow pyrshep ca>
+ * dialog-cell-format-cond.c (cb_c_fmt_dialog_chooser_entry_changed):
+ change signature
+ (c_fmt_dialog_init_editor_page): don't trigger parsing of the expression
+ entries on any change. This would cause problems with conversion into
+ strings.
+
+2011-07-11 Andreas J. Guelzow <aguelzow pyrshep ca>
+
* dialog-cell-format.c (cb_fmt_dialog_dialog_buttons): in the case
of style editing we need the complete style.
diff --git a/src/dialogs/dialog-cell-format-cond.c b/src/dialogs/dialog-cell-format-cond.c
index 9ce9c11..a6c88fa 100644
--- a/src/dialogs/dialog-cell-format-cond.c
+++ b/src/dialogs/dialog-cell-format-cond.c
@@ -213,7 +213,8 @@ cb_c_fmt_dialog_chooser_type_changed (G_GNUC_UNUSED GtkComboBox *widget, CFormat
}
static void
-cb_c_fmt_dialog_chooser_entry_changed (G_GNUC_UNUSED GnmExprEntry *widget, CFormatState *state)
+cb_c_fmt_dialog_chooser_entry_changed (G_GNUC_UNUSED GnmExprEntry *widget, G_GNUC_UNUSED GdkEvent *event,
+ CFormatState *state)
{
c_fmt_dialog_set_sensitive (state);
}
@@ -1163,11 +1164,11 @@ c_fmt_dialog_init_editor_page (CFormatState *state)
g_signal_connect (G_OBJECT (state->editor.combo),
"changed",
G_CALLBACK (cb_c_fmt_dialog_chooser_type_changed), state);
- g_signal_connect (G_OBJECT (state->editor.expr_x),
- "changed",
+ g_signal_connect (G_OBJECT (gnm_expr_entry_get_entry (GNM_EXPR_ENTRY (state->editor.expr_x))),
+ "focus-out-event",
G_CALLBACK (cb_c_fmt_dialog_chooser_entry_changed), state);
- g_signal_connect (G_OBJECT (state->editor.expr_y),
- "changed",
+ g_signal_connect (G_OBJECT (gnm_expr_entry_get_entry (GNM_EXPR_ENTRY (state->editor.expr_y))),
+ "focus-out-event",
G_CALLBACK (cb_c_fmt_dialog_chooser_entry_changed), state);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]