[clutter/wip/stable-paint-box: 1/4] paint-volume: don't round paint-volume from allocation
- From: Robert Bragg <rbragg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [clutter/wip/stable-paint-box: 1/4] paint-volume: don't round paint-volume from allocation
- Date: Tue, 12 Jul 2011 11:41:19 +0000 (UTC)
commit 2f4f5c5e9cc78885d36c49988b01a8fcf4abcbe8
Author: Robert Bragg <robert linux intel com>
Date: Tue Jul 12 00:44:47 2011 +0100
paint-volume: don't round paint-volume from allocation
The implementation of _clutter_actor_set_default_paint_volume which
simply uses the actor's allocation to determine a paint-volume was
needlessly using the allocation rounded to integers by internally using
clutter_actor_get_allocation_geometry instead of
clutter_actor_get_allocation_box. This was introducing a lot of
instability into the paint-volume due to the way rounding was done.
The code has now been updated to use clutter_actor_get_allocation_box
so we are dealing with the floating point allocation instead.
clutter/clutter-paint-volume.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/clutter/clutter-paint-volume.c b/clutter/clutter-paint-volume.c
index c4b2343..7b01e24 100644
--- a/clutter/clutter-paint-volume.c
+++ b/clutter/clutter-paint-volume.c
@@ -952,7 +952,7 @@ _clutter_actor_set_default_paint_volume (ClutterActor *self,
GType check_gtype,
ClutterPaintVolume *volume)
{
- ClutterGeometry geometry = { 0, };
+ ClutterActorBox box;
if (check_gtype != G_TYPE_INVALID)
{
@@ -967,14 +967,14 @@ _clutter_actor_set_default_paint_volume (ClutterActor *self,
if (!clutter_actor_has_allocation (self))
return FALSE;
- clutter_actor_get_allocation_geometry (self, &geometry);
+ clutter_actor_get_allocation_box (self, &box);
/* a zero-sized actor has no paint volume */
- if (geometry.width == 0 || geometry.height == 0)
+ if (box.x1 == box.x2 || box.y1 == box.y2)
return FALSE;
- clutter_paint_volume_set_width (volume, geometry.width);
- clutter_paint_volume_set_height (volume, geometry.height);
+ clutter_paint_volume_set_width (volume, box.x2 - box.x1);
+ clutter_paint_volume_set_height (volume, box.y2 - box.y1);
return TRUE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]