[tracker/thunderbird] thunderbird: Use a proper version comparison function
- From: Martyn James Russell <mr src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker/thunderbird] thunderbird: Use a proper version comparison function
- Date: Thu, 28 Jul 2011 13:30:07 +0000 (UTC)
commit 454af4a55006d9852b5513a0c4c108d4e514aaec
Author: Martyn Russell <martyn lanedo com>
Date: Thu Jul 28 14:28:46 2011 +0100
thunderbird: Use a proper version comparison function
Right now, we fix the v5.0b3 version by truncating the string, but if we have
a v5.1 then this also won't work. This does a proper comparison.
configure.ac | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index 0ce38b6..f48c67f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -399,13 +399,12 @@ have_tracker_miner_thunderbird="no "
AC_PATH_PROG(THUNDERBIRD, thunderbird, thunderbird)
if test -n $THUNDERBIRD; then
- thunderbird_version=`$THUNDERBIRD --version | cut -d" " -f3 | head -c3`
+ thunderbird_version=`$THUNDERBIRD --version | cut -d" " -f3`
- # This is a crappy way to do it, we should improve this.
- if test "$thunderbird_version" = "$TRACKER_MINER_THUNDERBIRD_REQUIRED" ; then
- AC_SUBST(THUNDERBIRD)
- have_tracker_miner_thunderbird=yes
- fi
+ AX_COMPARE_VERSION([$thunderbird_version], ge, [$TRACKER_MINER_THUNDERBIRD_REQUIRED],
+ have_tracker_miner_thunderbird="yes",
+ have_tracker_miner_thunderbird="no ")
+ AC_SUBST(THUNDERBIRD)
fi
# Check requirements for tracker-miner-rss
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]