[vala/emit-let: 4/5] codegen: Drop useless comma expression in GSignal module
- From: Luca Bruno <lucabru src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vala/emit-let: 4/5] codegen: Drop useless comma expression in GSignal module
- Date: Thu, 3 Mar 2011 18:57:10 +0000 (UTC)
commit b3f5d71a2e7b7137ea89954759487e0b4f8af452
Author: Luca Bruno <lucabru src gnome org>
Date: Thu Mar 3 19:44:18 2011 +0100
codegen: Drop useless comma expression in GSignal module
codegen/valagsignalmodule.vala | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/codegen/valagsignalmodule.vala b/codegen/valagsignalmodule.vala
index fd55878..5ee461e 100644
--- a/codegen/valagsignalmodule.vala
+++ b/codegen/valagsignalmodule.vala
@@ -172,10 +172,8 @@ public class Vala.GSignalModule : GObjectModule {
ccall.add_argument (get_cvalue (detail_expr));
ccall.add_argument (new CCodeConstant ("NULL"));
- var ccomma = new CCodeCommaExpression ();
- ccomma.append_expression (new CCodeAssignment (get_variable_cexpression (detail_decl.name), ccall));
- ccomma.append_expression (get_variable_cexpression (detail_decl.name));
- return ccomma;
+ ccode.add_assignment (get_variable_cexpression (detail_decl.name), ccall);
+ return get_variable_cexpression (detail_decl.name);
}
public override void visit_signal (Signal sig) {
@@ -482,7 +480,7 @@ public class Vala.GSignalModule : GObjectModule {
}
public override void visit_element_access (ElementAccess expr) {
- if (expr.container is MemberAccess && expr.container.symbol_reference is Signal) {
+ if (expr.container is MemberAccess && expr.container.symbol_reference is Signal && expr.parent_node is MethodCall) {
// detailed signal emission
var sig = (Signal) expr.symbol_reference;
var ma = (MemberAccess) expr.container;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]