[gnome-shell] dash: during drag, only offer trash can when dragging favorites

[Owen Taylor <otaylor src gnome org>]

commit 019670b5ab9287901ca1bc3ac086c6a9f83d90be
Author: Owen W. Taylor <otaylor fishsoup net>
Date:   Tue May 3 13:22:06 2011 -0400

    dash: during drag, only offer trash can when dragging favorites
    
    We should only show the trash can when the user starts dragging a
    favorite from the dash, not when the user starts dragging an application
    that happens to be a favorite via a window or an application icon
    in the applications view.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=642895

 js/ui/dash.js |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/dash.js b/js/ui/dash.js
index af9f1b4..10f1408 100644
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -342,7 +342,10 @@ Dash.prototype = {
 
         let srcIsFavorite = (id in favorites);
 
-        if (srcIsFavorite && this._favRemoveTarget == null) {
+        if (srcIsFavorite &&
+            dragEvent.source.actor &&
+            this.actor.contains (dragEvent.source.actor) &&
+            this._favRemoveTarget == null) {
                 this._favRemoveTarget = new RemoveFavoriteIcon();
                 this._favRemoveTarget.icon.setIconSize(this.iconSize);
                 this._box.add(this._favRemoveTarget.actor);