[gnome-shell] WindowDimmer: Make effect private
- From: Adel Gadllah <agadllah src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] WindowDimmer: Make effect private
- Date: Mon, 3 Oct 2011 16:22:42 +0000 (UTC)
commit 0968e556face59788dcb1f95fe50d13347f31126
Author: Adel Gadllah <adel gadllah gmail com>
Date: Mon Oct 3 18:21:19 2011 +0200
WindowDimmer: Make effect private
There is no need for making this public as it is only accessed from within
WindowDimmer.
js/ui/windowManager.js | 23 +++++++++++------------
1 files changed, 11 insertions(+), 12 deletions(-)
---
diff --git a/js/ui/windowManager.js b/js/ui/windowManager.js
index ab82c06..13f6e0a 100644
--- a/js/ui/windowManager.js
+++ b/js/ui/windowManager.js
@@ -38,10 +38,9 @@ function WindowDimmer(actor) {
WindowDimmer.prototype = {
_init: function(actor) {
if (Clutter.feature_available(Clutter.FeatureFlags.SHADERS_GLSL)) {
- this.effect = new Clutter.ShaderEffect({ shader_type: Clutter.ShaderType.FRAGMENT_SHADER });
- this.effect.set_shader_source(getDimShaderSource());
- }
- else {
+ this._effect = new Clutter.ShaderEffect({ shader_type: Clutter.ShaderType.FRAGMENT_SHADER });
+ this._effect.set_shader_source(getDimShaderSource());
+ } else {
this._effect = null;
}
@@ -51,23 +50,23 @@ WindowDimmer.prototype = {
set dimFraction(fraction) {
this._dimFraction = fraction;
- if (this.effect == null)
+ if (this._effect == null)
return;
if (!Meta.prefs_get_attach_modal_dialogs()) {
- this.effect.enabled = false;
+ this._effect.enabled = false;
return;
}
if (fraction > 0.01) {
- Shell.shader_effect_set_double_uniform(this.effect, 'height', this.actor.get_height());
- Shell.shader_effect_set_double_uniform(this.effect, 'fraction', fraction);
+ Shell.shader_effect_set_double_uniform(this._effect, 'height', this.actor.get_height());
+ Shell.shader_effect_set_double_uniform(this._effect, 'fraction', fraction);
- if (!this.effect.actor)
- this.actor.add_effect(this.effect);
+ if (!this._effect.actor)
+ this.actor.add_effect(this._effect);
} else {
- if (this.effect.actor)
- this.actor.remove_effect(this.effect);
+ if (this._effect.actor)
+ this.actor.remove_effect(this._effect);
}
},
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]