[gnome-shell] Silently add chat source in the MessageTray
- From: Xavier Claessens <xclaesse src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] Silently add chat source in the MessageTray
- Date: Mon, 19 Sep 2011 14:19:36 +0000 (UTC)
commit c23919df15b0b8b1aaf71c6a4441be76650b24a1
Author: Xavier Claessens <xclaesse gmail com>
Date: Thu Sep 15 11:27:11 2011 +0200
Silently add chat source in the MessageTray
We don't want the tray bar to open/close quickly when adding a chat because
it happens when user opens the chat from Empathy. The notification will
popup on incoming message anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=657249
js/ui/messageTray.js | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 6de4b7a..9476d7a 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1495,8 +1495,11 @@ MessageTray.prototype = {
// after notifications are done showing. However, we don't want that to happen for
// transient sources, which are removed after the notification is shown, but are
// not removed fast enough because of the callbacks to avoid the summary popping up.
- // So we just don't add transient sources to this._newSummaryItems .
- if (!source.isTransient)
+ // So we just don't add transient sources to this._newSummaryItems.
+ // We don't want that to happen for chat sources neither, because they
+ // can be added when the user starts a chat from Empathy and they are not transient.
+ // The notification will popup on incoming message anyway. See bug #657249.
+ if (!source.isTransient && !source.isChat)
this._newSummaryItems.push(summaryItem);
source.connect('notify', Lang.bind(this, this._onNotify));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]