[gnome-shell] NetworkMenu: fix crash when NetworkManger restarts



commit b6aab53d10d1db4808fd7cdaf248a91344a2d36a
Author: Giovanni Campagna <gcampagna src gnome org>
Date:   Thu Mar 29 18:51:03 2012 +0200

    NetworkMenu: fix crash when NetworkManger restarts
    
    nm_active_connection_get_devices() has a (questionable) special case
    for the no devices case (which happens if the DBus object is
    destroyed because NM went down): it returns null instead of an empty
    array. Handle that instead of crashing.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673043

 js/ui/status/network.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 5c6babe..f7d2258 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -1844,7 +1844,7 @@ const NMApplet = new Lang.Class({
                 if (a._type != NetworkManager.SETTING_VPN_SETTING_NAME) {
                     // find a good device to be considered primary
                     a._primaryDevice = null;
-                    let devices = a.get_devices();
+                    let devices = a.get_devices() || [];
                     for (let j = 0; j < devices.length; j++) {
                         let d = devices[j];
                         if (d._delegate) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]