[clutter] x11/stage: Leave a comment about multi-head setup
- From: Emmanuele Bassi <ebassi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [clutter] x11/stage: Leave a comment about multi-head setup
- Date: Tue, 10 Apr 2012 12:39:39 +0000 (UTC)
commit 25bf0b72f65ad7f7c931581f6ccb9e266addb3bc
Author: Emmanuele Bassi <ebassi linux intel com>
Date: Tue Apr 10 12:34:54 2012 +0100
x11/stage: Leave a comment about multi-head setup
The get_geometry() implementation is broken on multi-head systems; the
only solution is to use XRandR to get the size of the CRTC that contains
the stage.
clutter/x11/clutter-stage-x11.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/clutter/x11/clutter-stage-x11.c b/clutter/x11/clutter-stage-x11.c
index 48d71f4..c02b751 100644
--- a/clutter/x11/clutter-stage-x11.c
+++ b/clutter/x11/clutter-stage-x11.c
@@ -208,7 +208,14 @@ clutter_stage_x11_get_geometry (ClutterStageWindow *stage_window,
geometry->x = geometry->y = 0;
- /* If we're fullscreen, return the size of the display. */
+ /* If we're fullscreen, return the size of the display.
+ *
+ * FIXME - this is utterly broken for anything that is not a single
+ * head set up; the window manager will give us the right size in a
+ * ConfigureNotify, but between the fullscreen signal emission on the
+ * stage and the following frame, the size returned by the stage will
+ * be wrong.
+ */
if (_clutter_stage_is_fullscreen (stage_cogl->wrapper) &&
stage_x11->fullscreening)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]