[gnome-shell/wip/re-search-v2: 24/33] dash: fix for shrinking dash while animating
- From: Cosimo Cecchi <cosimoc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/re-search-v2: 24/33] dash: fix for shrinking dash while animating
- Date: Mon, 3 Dec 2012 09:57:37 +0000 (UTC)
commit c15b9cef668b9b39d4cf314730bb4c822533f0d5
Author: Tanner Doshier <doshitan gmail com>
Date: Thu Aug 16 19:59:33 2012 -0500
dash: fix for shrinking dash while animating
The this.actor.height > this._maxHeight check is needed because animating the
dash out causes constant notify::height signals and so after each one the max
height would shrink to the actor height causing the icons to shrink until
eventually we get to 16px icons. This way, only increase maxHeight if the
actor can be drawn bigger than it is currently set.
https://bugzilla.gnome.org/show_bug.cgi?id=682050
js/ui/dash.js | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/dash.js b/js/ui/dash.js
index 3595a60..8ab86a5 100644
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -398,7 +398,8 @@ const Dash = new Lang.Class({
function() {
if (this._maxHeight != this.actor.height)
this._queueRedisplay();
- this._maxHeight = this.actor.height;
+ if (this.actor.height > this._maxHeight)
+ this._maxHeight = this.actor.height;
}));
this._workId = Main.initializeDeferredWork(this._box, Lang.bind(this, this._redisplay));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]