[gnome-shell/wip/re-search-v2: 23/29] messageTray: don't assume we're always visible in the overview
- From: Cosimo Cecchi <cosimoc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/re-search-v2: 23/29] messageTray: don't assume we're always visible in the overview
- Date: Tue, 4 Dec 2012 18:40:15 +0000 (UTC)
commit 2ffc715b772fc8b9c242a66b215a52c235d452b4
Author: Tanner Doshier <doshitan gmail com>
Date: Thu Aug 16 18:26:10 2012 -0500
messageTray: don't assume we're always visible in the overview
Since we'll hide the message tray when searching in a future commit.
https://bugzilla.gnome.org/show_bug.cgi?id=682050
js/ui/messageTray.js | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 6b7199e..edc162d 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1506,7 +1506,7 @@ const MessageTray = new Lang.Class({
this._overviewVisible = true;
this._grabHelper.ungrab(); // drop modal grab if necessary
this.actor.add_style_pseudo_class('overview');
- this._updateState();
+ this.show();
}));
Main.overview.connect('hiding', Lang.bind(this,
function() {
@@ -1786,6 +1786,11 @@ const MessageTray = new Lang.Class({
this._updateState();
},
+ show: function() {
+ this._traySummoned = true;
+ this._updateState();
+ },
+
_onNotify: function(source, notification) {
if (this._summaryBoxPointerItem && this._summaryBoxPointerItem.source == source) {
if (this._summaryBoxPointerState == State.HIDING) {
@@ -2032,14 +2037,14 @@ const MessageTray = new Lang.Class({
}
// Summary
- let summarySummoned = this._pointerInSummary || this._overviewVisible || this._traySummoned;
+ let summarySummoned = this._pointerInSummary || this._traySummoned;
let summaryPinned = this._pointerInTray || summarySummoned || this._locked;
let summaryHovered = this._pointerInTray || this._pointerInSummary;
let notificationsVisible = this._notificationState != State.HIDDEN;
let notificationsDone = !notificationsVisible && !notificationsPending;
- let summaryOptionalInOverview = this._overviewVisible && !this._locked && !summaryHovered;
+ let summaryOptionalInOverview = !this._locked && !summaryHovered;
let mustHideSummary = (notificationsPending && (notificationUrgent || summaryOptionalInOverview))
|| notificationsVisible || !Main.sessionMode.hasNotifications;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]