[glom] Share on Network: Add reassuring message when user removal fails.
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glom] Share on Network: Add reassuring message when user removal fails.
- Date: Thu, 2 Feb 2012 09:52:33 +0000 (UTC)
commit 04e3dab67bb7e2095aeb7c04445c7175c424f11c
Author: Murray Cumming <murrayc murrayc com>
Date: Thu Feb 2 10:51:38 2012 +0100
Share on Network: Add reassuring message when user removal fails.
* glom/frame_glom.cc: Add a stdout message saying the the
default user has been disabled, because the existing message
about the failure to remove the user looks at first like
a security problem.
I still do not know why removal fails, even though we do
change the ownership of the database.
ChangeLog | 11 +++++++++++
glom/frame_glom.cc | 6 ++++++
2 files changed, 17 insertions(+), 0 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index f7e5292..e99b7be 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,16 @@
2012-02-02 Murray Cumming <murrayc murrayc com>
+ Share on Network: Add reassuring message when user removal fails.
+
+ * glom/frame_glom.cc: Add a stdout message saying the the
+ default user has been disabled, because the existing message
+ about the failure to remove the user looks at first like
+ a security problem.
+ I still do not know why removal fails, even though we do
+ change the ownership of the database.
+
+2012-02-02 Murray Cumming <murrayc murrayc com>
+
test_selfhosting_new_empty_then_users: Test user removal.
* glom/base_db.[h|cc]: Move remove_user() and
diff --git a/glom/frame_glom.cc b/glom/frame_glom.cc
index 5b1990f..d027d1c 100644
--- a/glom/frame_glom.cc
+++ b/glom/frame_glom.cc
@@ -904,6 +904,12 @@ void Frame_Glom::on_menu_file_toggle_share(const Glib::RefPtr<Gtk::ToggleAction>
//Try to revoke it instead.
//TODO: Discover how to make remove_user() succeed.
disabled = disable_user(default_user);
+ if(disabled)
+ {
+ //This message should be reassuring if the user sees a previous error
+ //about the default user not being removed.
+ std::cout << G_STRFUNC << ": The default user could not be removed, but it has been disabled." << std::endl;
+ }
}
if(!reowned || !(removed || disabled))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]