[nautilus] pane: don't access invalid memory



commit 9d0f892656282519059d65f10db7504ad4910b22
Author: Cosimo Cecchi <cosimoc gnome org>
Date:   Mon Feb 6 12:25:58 2012 -0500

    pane: don't access invalid memory
    
    slot->pane is already cleared in nautilus_window_slot_dispose(), which
    will get called while the slot is destroyed; setting it here can cause
    an invalid memory access.

 src/nautilus-window-pane.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/src/nautilus-window-pane.c b/src/nautilus-window-pane.c
index 4e7a388..5172c59 100644
--- a/src/nautilus-window-pane.c
+++ b/src/nautilus-window-pane.c
@@ -1066,8 +1066,6 @@ nautilus_window_pane_close_slot (NautilusWindowPane *pane,
 
 	gtk_notebook_set_show_tabs (notebook,
 				    gtk_notebook_get_n_pages (notebook) > 1);
-
-	slot->pane = NULL;
 	pane->slots = g_list_remove (pane->slots, slot);
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]