[tasks/gnome3] Remove HANDLE_LIBICAL_MEMORY, the ring buffer is good as strings get duplicated
- From: Ross Burton <rburton src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tasks/gnome3] Remove HANDLE_LIBICAL_MEMORY, the ring buffer is good as strings get duplicated
- Date: Thu, 23 Feb 2012 13:34:58 +0000 (UTC)
commit b023f1c4295d1eaa8799cca949dbe92f46c64dc9
Author: Ross Burton <ross burton intel com>
Date: Thu Feb 23 13:32:44 2012 +0000
Remove HANDLE_LIBICAL_MEMORY, the ring buffer is good as strings get duplicated
TODO | 1 -
configure.ac | 2 --
libkoto/koto-field-editor-factory.c | 5 +----
3 files changed, 1 insertions(+), 7 deletions(-)
---
diff --git a/TODO b/TODO
index 38e45d6..32453c8 100644
--- a/TODO
+++ b/TODO
@@ -1,3 +1,2 @@
port to gtkapplication
-remove handle_libical_memory?
remove cell renderer?
diff --git a/configure.ac b/configure.ac
index ff1c500..fc46cd0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -24,8 +24,6 @@ AM_GLIB_GNU_GETTEXT
PKG_CHECK_MODULES(GTK, gtk+-3.0 >= 3.2)
PKG_CHECK_MODULES(ECAL, libecal-1.2)
-AC_DEFINE(HANDLE_LIBICAL_MEMORY, 1, [we free libical memory])
-
AC_ARG_ENABLE(gtk,
AS_HELP_STRING([--enable-gtk],[Build the GTK frontend]),
,enable_gtk=yes)
diff --git a/libkoto/koto-field-editor-factory.c b/libkoto/koto-field-editor-factory.c
index 39da471..687ac0c 100644
--- a/libkoto/koto-field-editor-factory.c
+++ b/libkoto/koto-field-editor-factory.c
@@ -336,7 +336,7 @@ text_new (void)
static void
text_set (GtkWidget *widget, icalproperty *prop)
{
- char *text = NULL;
+ const char *text = NULL;
char *s;
GtkWidget *textview;
GtkTextBuffer *buffer;
@@ -360,9 +360,6 @@ text_set (GtkWidget *widget, icalproperty *prop)
s = g_strcompress (text);
gtk_text_buffer_set_text (buffer, s, -1);
g_free (s);
-#if LIBICAL_MEMFIXES
- g_free (text);
-#endif
} else {
gtk_text_buffer_set_text (buffer, "", -1);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]