[cogl/cogl-1.10] Visual C++ support: Re-enable C4819 warnings



commit 6375f95964b41d47c281b2e5c338880311453f83
Author: Chun-wei Fan <fanchunwei src gnome org>
Date:   Fri Jul 20 15:51:21 2012 +0800

    Visual C++ support: Re-enable C4819 warnings
    
    The C4819 warnings appear due to a bug on Visual C++ when running on
    non-English locales, specifically CJK versions/locales of Windows.
    
    Re-enable this, like what is done in GLib, and add a note in the Visual
    C++ README.txt's to tell people about this, so that Cogl will be built
    correctly.

 build/win32/vs10/README.txt  |    7 +++++++
 build/win32/vs10/cogl.props  |    4 ++--
 build/win32/vs9/README.txt   |    7 +++++++
 build/win32/vs9/cogl.vsprops |    1 -
 4 files changed, 16 insertions(+), 3 deletions(-)
---
diff --git a/build/win32/vs10/README.txt b/build/win32/vs10/README.txt
index e291430..72e25b0 100644
--- a/build/win32/vs10/README.txt
+++ b/build/win32/vs10/README.txt
@@ -69,5 +69,12 @@ built DLLs go into <root>\vs10\<PlatformName>\bin, built LIBs into
  ftp://ftp.gnome.org/pub/GNOME/binaries/win32/dependencies/ (32 bit)
  ftp://ftp.gnome.org/pub/GNOME/binaries/win64/dependencies/ (64 bit)
 
+Note: If you see C4819 warnings and you are compiling Cogl on a DBCS
+(Chinese/Korean/Japanese) version of Windows, you may need to switch
+to an English locale in Control Panel->Region and Languages->System->
+Change System Locale, reboot and rebuild to ensure Cogl and its
+dependencies are built correctly.  This is due to a bug in Visual C++
+running on DBCS locales.
+
 --Chun-wei Fan <fanc999 yahoo com tw>
   (Adopted from the GTK+ Win32 VS README.txt file originally by Tor Lillqvist)
diff --git a/build/win32/vs10/cogl.props b/build/win32/vs10/cogl.props
index 9497f27..992fc5f 100644
--- a/build/win32/vs10/cogl.props
+++ b/build/win32/vs10/cogl.props
@@ -219,7 +219,7 @@ copy ..\..\..\cogl\cogl2-compatibility.h $(CopyDir)\include\cogl-$(CoglApiVersio
       <AdditionalIncludeDirectories>..\..\..;..\..\..\cogl;..\..\..\cogl\winsys;$(GlibEtcInstallRoot)\include;$(GlibEtcInstallRoot)\include\glib-2.0;$(GlibEtcInstallRoot)\include\cairo;$(GlibEtcInstallRoot)\include\pango-1.0;$(GlibEtcInstallRoot)\include\gdk-pixbuf-2.0;$(GlibEtcInstallRoot)\lib\glib-2.0\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
       <PreprocessorDefinitions>G_DISABLE_SINGLE_INCLUDES;COGL_HAS_GLIB_SUPPORT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ForcedIncludeFiles>msvc_recommended_pragmas.h;%(ForcedIncludeFiles)</ForcedIncludeFiles>
-      <DisableSpecificWarnings>4819;%(DisableSpecificWarnings)</DisableSpecificWarnings>
+      <DisableSpecificWarnings>%(DisableSpecificWarnings)</DisableSpecificWarnings>
     </ClCompile>
     <Link>
       <AdditionalDependencies>glib-2.0.lib;gobject-2.0.lib;%(AdditionalDependencies)</AdditionalDependencies>
@@ -294,4 +294,4 @@ copy ..\..\..\cogl\cogl2-compatibility.h $(CopyDir)\include\cogl-$(CoglApiVersio
       <Value>$(CoglDllSuffix)</Value>
     </BuildMacro>
   </ItemGroup>
-</Project>
\ No newline at end of file
+</Project>
diff --git a/build/win32/vs9/README.txt b/build/win32/vs9/README.txt
index 4c4b45a..c2f459a 100644
--- a/build/win32/vs9/README.txt
+++ b/build/win32/vs9/README.txt
@@ -75,5 +75,12 @@ built DLLs go into <root>\vs9\<PlatformName>\bin, built LIBs into
   ftp://ftp.gnome.org/pub/GNOME/binaries/win32/dependencies/ (32 bit)
   ftp://ftp.gnome.org/pub/GNOME/binaries/win64/dependencies/ (64 bit)
 
+Note: If you see C4819 warnings and you are compiling Cogl on a DBCS
+(Chinese/Korean/Japanese) version of Windows, you may need to switch
+to an English locale in Control Panel->Region and Languages->System->
+Change System Locale, reboot and rebuild to ensure Cogl and its
+dependencies are built correctly.  This is due to a bug in Visual C++
+running on DBCS locales.
+
 --Chun-wei Fan <fanc999 yahoo com tw>
   (Adopted from the GTK+ Win32 VS README.txt file originally by Tor Lillqvist)
diff --git a/build/win32/vs9/cogl.vsprops b/build/win32/vs9/cogl.vsprops
index ef4de04..42b9b02 100644
--- a/build/win32/vs9/cogl.vsprops
+++ b/build/win32/vs9/cogl.vsprops
@@ -11,7 +11,6 @@
 		AdditionalIncludeDirectories="..\..\..;..\..\..\cogl;..\..\..\cogl\winsys;$(GlibEtcInstallRoot)\include;$(GlibEtcInstallRoot)\include\glib-2.0;$(GlibEtcInstallRoot)\include\cairo;$(GlibEtcInstallRoot)\include\pango-1.0;$(GlibEtcInstallRoot)\include\gdk-pixbuf-2.0;$(GlibEtcInstallRoot)\lib\glib-2.0\include"
 		PreprocessorDefinitions="G_DISABLE_SINGLE_INCLUDES;COGL_HAS_GLIB_SUPPORT"
 		ForcedIncludeFiles="msvc_recommended_pragmas.h"
-		DisableSpecificWarnings="4819"
 	/>
 	<Tool
 		Name="VCLinkerTool"



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]