[gnome-settings-daemon] xrandr: Fix the rotate display button not working
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-settings-daemon] xrandr: Fix the rotate display button not working
- Date: Fri, 9 Mar 2012 11:14:24 +0000 (UTC)
commit 1ea595a790ae415e100796ab4a31a9f73a72c52a
Author: Sjoerd Simons <sjoerd luon net>
Date: Fri Mar 9 12:08:16 2012 +0100
xrandr: Fix the rotate display button not working
When hitting the XF86RotateWindows the screen just goes black instead of
actually rotating the screen as intending (with the output turned off).
Turns out that gnome-settings-daemon is trying to rotate the screen to
an invalid value. GnomeRRRotation is an enum with only values >= 0, so
it is likely to be made unsigned. As the rotation argument to
handle_rotate_windows can be -1 to indicate ``next possible rotation'',
rotation can't be a GnomeRRRotation as that won't be < 0.
https://bugzilla.gnome.org/show_bug.cgi?id=664363
configure.ac | 2 +-
plugins/xrandr/gsd-xrandr-manager.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index 6b437d8..e6e258b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -47,7 +47,7 @@ GLIB_REQUIRED_VERSION=2.31.0
GTK_REQUIRED_VERSION=3.3.4
GCONF_REQUIRED_VERSION=2.6.1
GIO_REQUIRED_VERSION=2.26.0
-GNOME_DESKTOP_REQUIRED_VERSION=3.3.4
+GNOME_DESKTOP_REQUIRED_VERSION=3.3.92
LIBNOTIFY_REQUIRED_VERSION=0.7.3
UPOWER_GLIB_REQUIRED_VERSION=0.9.1
PA_REQUIRED_VERSION=0.9.16
diff --git a/plugins/xrandr/gsd-xrandr-manager.c b/plugins/xrandr/gsd-xrandr-manager.c
index d02c1ab..b4363e3 100644
--- a/plugins/xrandr/gsd-xrandr-manager.c
+++ b/plugins/xrandr/gsd-xrandr-manager.c
@@ -764,7 +764,7 @@ gsd_xrandr_manager_2_rotate (GsdXrandrManager *manager,
guint32 timestamp,
GError **error)
{
- handle_rotate_windows (manager, -1, timestamp);
+ handle_rotate_windows (manager, GNOME_RR_ROTATION_NEXT, timestamp);
return TRUE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]