[gnome-online-accounts/facebook: 3/6] configure.ac: remove the facebook client secret



commit fab15e60390eb5d12646ec44f101a1b9f83a9b25
Author: Cosimo Alfarano <cosimo alfarano collabora com>
Date:   Wed Mar 14 14:08:59 2012 +0000

    configure.ac: remove the facebook client secret
    
    The client secret is now obsoleted by the client-side auth flow use.
    Hardcode an already existing "GNOME" Facebook app id.
    
    Fixes: https://bugzilla.gnome.org/672060

 configure.ac |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index c6a1396..b2345bc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -147,7 +147,10 @@ if test "$enable_yahoo" != "no"; then
 fi
 
 # Facebook
-AC_ARG_ENABLE([facebook], [AS_HELP_STRING([--enable-facebook], [Enable Facebook provider])], [], [enable_facebook=no])
+AC_ARG_ENABLE([facebook], [AS_HELP_STRING([--enable-facebook],
+					  [Enable Facebook provider])],
+					  [],
+					  [enable_facebook=yes])
 AC_ARG_WITH(facebook-client-id,
             [AS_HELP_STRING([--with-facebook-client-id],
                             [Facebook OAuth 2.0 client id])],
@@ -159,13 +162,9 @@ AC_ARG_WITH(facebook-client-secret,
                             [],
                             [])
 if test "$with_facebook_client_id" = ""; then
-  with_facebook_client_id=not_set
-fi
-if test "$with_facebook_client_secret" = ""; then
-  with_facebook_client_secret=not_set
+  with_facebook_client_id=297654143624603
 fi
 AC_DEFINE_UNQUOTED(GOA_FACEBOOK_CLIENT_ID, ["$with_facebook_client_id"], [Facebook OAuth 2.0 client id])
-AC_DEFINE_UNQUOTED(GOA_FACEBOOK_CLIENT_SECRET, ["$with_facebook_client_secret"], [Facebook OAuth 2.0 client secret])
 if test "$enable_facebook" != "no"; then
   AC_DEFINE(GOA_FACEBOOK_ENABLED, 1, [Enable Facebook data provider])
 fi
@@ -246,7 +245,7 @@ echo "
 	Google provider:            ${enable_google} (OAuth 1.0, key:${with_google_consumer_key} secret:${with_google_consumer_secret})
 	Twitter provider:           ${enable_twitter} (OAuth 1.0, key:${with_twitter_consumer_key} secret:${with_twitter_consumer_secret})
 	Yahoo provider:             ${enable_yahoo} (OAuth 1.0, key:${with_yahoo_consumer_key} secret:${with_yahoo_consumer_secret})
-	Facebook provider:          ${enable_facebook} (OAuth 2.0, id:${with_facebook_client_id} secret:${with_facebook_client_secret})
+	Facebook provider:          ${enable_facebook} (OAuth 2.0, id:${with_facebook_client_id})
 	Windows Live provider:      ${enable_windows_live} (OAuth 2.0, id:${with_windows_live_client_id})
 
         Maintainer mode:            ${USE_MAINTAINER_MODE}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]