[libgnomekbd] Fix up split_items usage
- From: Sergey V. Udaltsov <svu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgnomekbd] Fix up split_items usage
- Date: Mon, 26 Mar 2012 19:18:22 +0000 (UTC)
commit ffaf5489fad6588b50384e944c56284e9edef222
Author: Ray Strode <rstrode redhat com>
Date: Mon Mar 26 10:43:13 2012 -0400
Fix up split_items usage
commit c9d3c0e939c21230d6088aaf915d9b7d965d97d8 introduced a couple
of calls to gkbd_keyboard_config_split_items with the incorrect
assumption that those calls return newly allocated memory.
This commit drops the wrong free calls.
https://bugzilla.gnome.org/show_bug.cgi?id=670164
libgnomekbd/gkbd-keyboard-config.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
---
diff --git a/libgnomekbd/gkbd-keyboard-config.c b/libgnomekbd/gkbd-keyboard-config.c
index 8ae216b..2f15a42 100644
--- a/libgnomekbd/gkbd-keyboard-config.c
+++ b/libgnomekbd/gkbd-keyboard-config.c
@@ -526,18 +526,12 @@ gkbd_keyboard_config_options_equals (GkbdKeyboardConfig * kbd_config1,
if (!gkbd_keyboard_config_split_items (kbd_config1->options[i], &group1, &option1))
continue;
- g_free (group1);
-
for (j = 0; j < num_options && !are_equal; j++) {
if (gkbd_keyboard_config_split_items (kbd_config2->options[j], &group2, &option2)) {
are_equal = strcmp (option1, option2) == 0;
- g_free (group2);
- g_free (option2);
}
}
- g_free (option1);
-
if (!are_equal)
return False;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]