[extensions-web] extensions: Fix extension installation
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [extensions-web] extensions: Fix extension installation
- Date: Thu, 29 Mar 2012 23:26:32 +0000 (UTC)
commit 3db545338fd393f632a4dae039409eabe33b76c3
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Thu Mar 29 19:26:18 2012 -0400
extensions: Fix extension installation
version_tag is not an integer, it is a string. GET parameters are never
implicitly converted to integers, dammit.
sweettooth/extensions/views.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/sweettooth/extensions/views.py b/sweettooth/extensions/views.py
index 4a9d97b..9559cae 100644
--- a/sweettooth/extensions/views.py
+++ b/sweettooth/extensions/views.py
@@ -49,9 +49,9 @@ def get_versions_for_version_strings(version_strings):
def shell_download(request, uuid):
extension = get_object_or_404(models.Extension, uuid=uuid)
- if request.GET.get('version_tag', -1) >= 0:
+ if request.GET.get('version_tag', ''):
try:
- version = extension.visible_versions.get(pk=request.GET['version_tag'])
+ version = extension.visible_versions.get(pk=int(request.GET['version_tag']))
except models.ExtensionVersion.DoesNotExist:
raise Http404()
else:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]