[libsoup] Crash in lookup_resolved(), g_error_free()
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libsoup] Crash in lookup_resolved(), g_error_free()
- Date: Thu, 15 Nov 2012 08:00:09 +0000 (UTC)
commit b2c900e20590c2fce99c4c37920fd2962dd0b955
Author: Milan Crha <mcrha redhat com>
Date: Thu Nov 15 08:58:15 2012 +0100
Crash in lookup_resolved(), g_error_free()
The problem is that g_task_return_error() "eats" the error,
it doesn't create its own copy, thus, in this case, copy the error.
https://bugzilla.gnome.org/show_bug.cgi?id=688330
libsoup/soup-address.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libsoup/soup-address.c b/libsoup/soup-address.c
index 521ff76..82beb1e 100644
--- a/libsoup/soup-address.c
+++ b/libsoup/soup-address.c
@@ -1116,7 +1116,7 @@ got_addresses (SoupAddress *addr, guint status, gpointer user_data)
error = g_object_get_data (G_OBJECT (addr), "async-resolved-error");
if (error)
- g_task_return_error (task, error);
+ g_task_return_error (task, g_error_copy (error));
else {
GSocketAddress *addr;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]