[gvfs] gvfs-test: Skip Sftp.test_unknown_host when not in gvfs-testbed



commit 46b4898edc221eff6e1caffae894fc5a6f8d42ed
Author: Martin Pitt <martinpitt gnome org>
Date:   Tue Nov 27 17:50:43 2012 +0100

    gvfs-test: Skip Sftp.test_unknown_host when not in gvfs-testbed
    
    When running under the normal user account, the StrictHostKeyChecking option is
    client-configurable behaviour which cannot be temporarily changed. Skip the
    test entirely in this case instead of exfailing it, as it does not test
    anything meaningful then.
    
    Drop the exfail so that the test must succeed when running under gvfs-testbed.

 test/gvfs-test |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/test/gvfs-test b/test/gvfs-test
index 6dbe74e..d82b9b4 100755
--- a/test/gvfs-test
+++ b/test/gvfs-test
@@ -433,7 +433,11 @@ Subsystem sftp %(sftp_server)s
 
         self.do_mount_check(uri)
 
-    @unittest.expectedFailure # https://bugzilla.gnome.org/show_bug.cgi?id=686006#c38
+    # if we are in the testbed, then ssh defaults to
+    # "StrictHostKeyChecking ask", and a connection attempt should fail;
+    # otherwise this is client-configurable behaviour which cannot be
+    # temporarily overridden
+    @unittest.skipUnless(in_testbed, 'not running under gvfs-testbed')
     @unittest.skipUnless(local_ip, 'not having any non-localhost IP')
     def test_unknown_host(self):
         '''sftp:// with RSA authentication for unknown host'''



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]