[glibmm] MenuItem: Rename the get_attribute_value() methods to get_attribute().
- From: Josà Alburquerque <jaalburqu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glibmm] MenuItem: Rename the get_attribute_value() methods to get_attribute().
- Date: Thu, 4 Oct 2012 11:28:40 +0000 (UTC)
commit b2a25eab196f5ed01d6cf49fdb4f9f9be20e8458
Author: Josà Alburquerque <jaalburqu svn gnome org>
Date: Thu Oct 4 07:28:04 2012 -0400
MenuItem: Rename the get_attribute_value() methods to get_attribute().
* gio/src/menuitem.hg: Rename the just added methods to just
get_attribute() instead of get_attribute_value() to make the method
name shorter. Also deprecate the set_attribute_value() method and add
a set_attribute() method to go with the newly renamed get_attribute()
methods.
ChangeLog | 10 ++++++++++
gio/src/menuitem.hg | 12 ++++--------
2 files changed, 14 insertions(+), 8 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 4759f73..6bb1c1b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2012-10-04 Josà Alburquerque <jaalburquerque gmail com>
+
+ MenuItem: Rename the get_attribute_value() methods to get_attribute().
+
+ * gio/src/menuitem.hg: Rename the just added methods to just
+ get_attribute() instead of get_attribute_value() to make the method
+ name shorter. Also deprecate the set_attribute_value() method and add
+ a set_attribute() method to go with the newly renamed get_attribute()
+ methods.
+
2012-10-03 Josà Alburquerque <jaalburquerque gmail com>
MountOperation: Wrap the "show-unmount-progesss" signal.
diff --git a/gio/src/menuitem.hg b/gio/src/menuitem.hg
index 04a1a32..4843da8 100644
--- a/gio/src/menuitem.hg
+++ b/gio/src/menuitem.hg
@@ -47,9 +47,8 @@ public:
//TODO: GMenuItem * g_menu_item_new_section (const Glib::ustring& label,
// const Glib::RefPtr<MenuModel>& section);
- //TODO: Maybe this method should just be called set_attribute? That would
- //probably require an API/ABI break.
- _WRAP_METHOD(void set_attribute_value(const Glib::ustring& attribute, const Glib::VariantBase& value), g_menu_item_set_attribute_value)
+ _WRAP_METHOD(void set_attribute_value(const Glib::ustring& attribute, const Glib::VariantBase& value), g_menu_item_set_attribute_value, deprecated "Use set_attribute() instead.")
+ _WRAP_METHOD(void set_attribute(const Glib::ustring& attribute, const Glib::VariantBase& value), g_menu_item_set_attribute_value)
_IGNORE(g_menu_item_set_attribute)
_WRAP_METHOD(Glib::RefPtr<MenuModel> get_link(const Glib::ustring& link), g_menu_item_get_link, refreturn)
@@ -60,11 +59,8 @@ public:
_WRAP_METHOD(void set_submenu(const Glib::RefPtr<MenuModel>& submenu), g_menu_item_set_submenu)
_WRAP_METHOD(void set_section(const Glib::RefPtr<MenuModel>& section), g_menu_item_set_section)
- //TODO: Maybe these methods should just be called get_attribute() (they are
- //called get_attribute_value() for consistency with the already existing
- //set_attribute_value() method above.
- _WRAP_METHOD(Glib::VariantBase get_attribute_value(const Glib::ustring& attribute, const Glib::VariantType& expected_type{?}), g_menu_item_get_attribute_value)
- _WRAP_METHOD(const Glib::VariantBase get_attribute_value(const Glib::ustring& attribute, const Glib::VariantType& expected_type{?}) const, g_menu_item_get_attribute_value, constversion)
+ _WRAP_METHOD(Glib::VariantBase get_attribute(const Glib::ustring& attribute, const Glib::VariantType& expected_type{?}), g_menu_item_get_attribute_value)
+ _WRAP_METHOD(const Glib::VariantBase get_attribute(const Glib::ustring& attribute, const Glib::VariantType& expected_type{?}) const, g_menu_item_get_attribute_value, constversion)
// Ignore varargs function.
_IGNORE(g_menu_item_get_attribute)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]