[gtk+/places-sidebar] Note about missing empty-trash functionality	when unmounting a volume.
- From: Federico Mena Quintero <federico src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [gtk+/places-sidebar] Note about missing empty-trash functionality	when unmounting a volume.
- Date: Tue, 30 Oct 2012 01:03:04 +0000 (UTC)
commit 5741b0e66110bfca9a34868cdaf4169cb856be97
Author: Federico Mena Quintero <federico gnome org>
Date:   Mon Oct 29 18:57:24 2012 -0600
    Note about missing empty-trash functionality when unmounting a volume.
    
    Signed-off-by: Federico Mena Quintero <federico gnome org>
 gtk/gtkplacessidebar.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
---
diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c
index cff5fc5..3fb2cc2 100644
--- a/gtk/gtkplacessidebar.c
+++ b/gtk/gtkplacessidebar.c
@@ -34,6 +34,12 @@
  * * Fix FIXMEs
  *
  * * Grep for "NULL-GError" and see if they should be taken care of
+ *
+ * * Although we do g_mount_unmount_with_operation(), Nautilus used to do
+ *   nautilus_file_operations_unmount_mount_full() to unmount a volume.  With
+ *   that, Nautilus does the "volume has trash, empty it first?" dance.  Cosimo
+ *   suggests that this logic should be part of GtkMountOperation, which can
+ *   have Unix-specific code for emptying trash.
  */
 
 #include "config.h"
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]