[gnome-shell] MessageTray: remove bad fast path in hideSummaryBoxPointer
- From: Giovanni Campagna <gcampagna src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] MessageTray: remove bad fast path in hideSummaryBoxPointer
- Date: Fri, 14 Sep 2012 16:31:34 +0000 (UTC)
commit 7654f1ca3ef4dbe8f61a6562bd9585ad13b01780
Author: Giovanni Campagna <gcampagna src gnome org>
Date: Fri Sep 14 18:16:36 2012 +0200
MessageTray: remove bad fast path in hideSummaryBoxPointer
The onUngrab callback already checks if all notifications are destroyed and
hides immediately if so. Previous code instead would leave state handling
in an inconsistent state, by not removing the grab, not setting
summaryBoxPointerState to HIDDEN and not disconnecting various signals.
https://bugzilla.gnome.org/show_bug.cgi?id=684036
js/ui/messageTray.js | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 1b64098..21687ee 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -2436,14 +2436,6 @@ const MessageTray = new Lang.Class({
},
_hideSummaryBoxPointer: function() {
- // We should be sure to hide the box pointer if all notifications in it are destroyed while
- // it is hiding, so that we don't show an animation of an empty blob being hidden.
- if (this._summaryBoxPointerState == State.HIDING &&
- this._summaryBoxPointerItem.notificationStack.get_n_children() == 0) {
- this._summaryBoxPointer.actor.hide();
- return;
- }
-
this._grabHelper.ungrab({ actor: this._summaryBoxPointer.bin.child });
},
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]