[gnome-control-center] region: Handle input sources in the system tab
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] region: Handle input sources in the system tab
- Date: Sun, 16 Sep 2012 19:53:36 +0000 (UTC)
commit 914e8b25629dbb1c8da83926098ecd7de9c2242f
Author: Bastien Nocera <hadess hadess net>
Date: Thu Sep 13 01:23:38 2012 +0100
region: Handle input sources in the system tab
Unfortunately we don't have a way yet to make gsettings system wide
defaults so we are just using the localed API to export the XKB input
sources and ignore the IBus ones.
https://bugzilla.gnome.org/show_bug.cgi?id=683875
panels/region/gnome-region-panel-input.c | 2 +-
panels/region/gnome-region-panel-input.h | 2 +
panels/region/gnome-region-panel-system.c | 157 ++++++++++++++++++++++++++++-
3 files changed, 155 insertions(+), 6 deletions(-)
---
diff --git a/panels/region/gnome-region-panel-input.c b/panels/region/gnome-region-panel-input.c
index aec7996..a48e55c 100644
--- a/panels/region/gnome-region-panel-input.c
+++ b/panels/region/gnome-region-panel-input.c
@@ -505,7 +505,7 @@ populate_model (GtkListStore *store,
g_hash_table_destroy (active_sources_table);
}
-static GVariant *
+GVariant *
create_source_from_current_xkb_config (void)
{
GVariantBuilder builder;
diff --git a/panels/region/gnome-region-panel-input.h b/panels/region/gnome-region-panel-input.h
index 47a1f52..bf32899 100644
--- a/panels/region/gnome-region-panel-input.h
+++ b/panels/region/gnome-region-panel-input.h
@@ -31,6 +31,8 @@ G_BEGIN_DECLS
void setup_input_tabs (GtkBuilder *builder,
CcRegionPanel *self);
+GVariant * create_source_from_current_xkb_config (void);
+
G_END_DECLS
#endif /* __GNOME_KEYBOARD_PROPERTY_INPUT_H */
diff --git a/panels/region/gnome-region-panel-system.c b/panels/region/gnome-region-panel-system.c
index c0941b6..1092ea6 100644
--- a/panels/region/gnome-region-panel-system.c
+++ b/panels/region/gnome-region-panel-system.c
@@ -29,13 +29,17 @@
#include <glib/gi18n.h>
+#define GNOME_DESKTOP_USE_UNSTABLE_API
+#include <libgnome-desktop/gnome-xkb-info.h>
+
#include "cc-common-language.h"
#include "gdm-languages.h"
#include "gnome-region-panel-system.h"
+#include "gnome-region-panel-input.h"
#define WID(s) GTK_WIDGET(gtk_builder_get_object (dialog, s))
-static GSettings *locale_settings;
+static GSettings *locale_settings, *input_sources_settings;
static GDBusProxy *localed_proxy;
static GPermission *localed_permission;
@@ -72,13 +76,14 @@ update_copy_button (GtkBuilder *dialog)
button = WID ("copy_settings_button");
- /* If the version of localed doesn't include layouts... */
- if (system_input_source) {
+ if (user_input_source && user_input_source[0]) {
layouts_differ = (g_strcmp0 (user_input_source, system_input_source) != 0);
if (layouts_differ == FALSE)
layouts_differ = (g_strcmp0 (user_input_variants, system_input_variants) != 0);
- } else
+ } else {
+ /* Nothing to copy */
layouts_differ = FALSE;
+ }
if (g_strcmp0 (user_lang, system_lang) == 0 &&
g_strcmp0 (user_region, system_region) == 0 &&
@@ -131,6 +136,75 @@ system_update_language (GtkBuilder *dialog, const gchar *language)
}
static void
+input_sources_changed (GSettings *settings,
+ const gchar *key,
+ GtkBuilder *dialog)
+{
+ GString *disp, *list, *variants;
+ GtkWidget *label;
+ GnomeXkbInfo *xkb_info;
+ GVariantIter iter;
+ GVariant *sources;
+ const gchar *type;
+ const gchar *id;
+
+ sources = g_settings_get_value (input_sources_settings, "sources");
+ if (g_variant_n_children (sources) < 1) {
+ g_variant_unref (sources);
+ sources = create_source_from_current_xkb_config ();
+ }
+
+ xkb_info = gnome_xkb_info_new ();
+
+ label = WID ("user_input_source");
+ disp = g_string_new ("");
+ list = g_string_new ("");
+ variants = g_string_new ("");
+
+ g_variant_iter_init (&iter, sources);
+ while (g_variant_iter_next (&iter, "(&s&s)", &type, &id)) {
+ /* We can't copy non-XKB layouts to the system yet */
+ if (g_str_equal (type, "xkb")) {
+ char **split;
+ gchar *layout, *variant;
+ const char *name;
+
+ gnome_xkb_info_get_layout_info (xkb_info, id, &name, NULL, NULL, NULL);
+ if (disp->str[0] != '\0')
+ g_string_append (disp, ", ");
+ g_string_append (disp, name);
+
+ split = g_strsplit (id, "+", 2);
+
+ if (split == NULL || split[0] == NULL)
+ continue;
+
+ layout = split[0];
+ variant = split[1];
+
+ if (list->str[0] != '\0') {
+ g_string_append (list, ",");
+ g_string_append (variants, ",");
+ }
+ g_string_append (list, layout);
+ g_string_append (variants, variant ? variant : "");
+
+ g_strfreev (split);
+ }
+ }
+ g_variant_unref (sources);
+ g_object_unref (xkb_info);
+
+ g_object_set_data_full (G_OBJECT (label), "input_source", g_string_free (list, FALSE), g_free);
+ g_object_set_data_full (G_OBJECT (label), "input_variants", g_string_free (variants, FALSE), g_free);
+
+ gtk_label_set_text (GTK_LABEL (label), disp->str);
+ g_string_free (disp, TRUE);
+
+ update_copy_button (dialog);
+}
+
+static void
update_property (GDBusProxy *proxy,
const char *property)
{
@@ -164,7 +238,13 @@ on_localed_properties_changed (GDBusProxy *proxy,
const gchar **invalidated_properties,
GtkBuilder *dialog)
{
- GVariant *v;
+ GVariant *v, *w;
+ GtkWidget *label;
+ GnomeXkbInfo *xkb_info;
+ char **layouts;
+ char **variants;
+ GString *disp;
+ guint i, n;
if (invalidated_properties != NULL) {
guint i;
@@ -173,6 +253,8 @@ on_localed_properties_changed (GDBusProxy *proxy,
update_property (proxy, "Locale");
else if (g_str_equal (invalidated_properties[i], "X11Layout"))
update_property (proxy, "X11Layout");
+ else if (g_str_equal (invalidated_properties[i], "X11Variant"))
+ update_property (proxy, "X11Variant");
}
}
@@ -224,6 +306,59 @@ on_localed_properties_changed (GDBusProxy *proxy,
g_variant_unref (v);
}
+ label = WID ("system_input_source");
+ v = g_dbus_proxy_get_cached_property (proxy, "X11Layout");
+ if (v) {
+ layouts = g_strsplit (g_variant_get_string (v, NULL), ",", -1);
+ g_object_set_data_full (G_OBJECT (label), "input_source",
+ g_variant_dup_string (v, NULL), g_free);
+ g_variant_unref (v);
+ } else {
+ g_object_set_data_full (G_OBJECT (label), "input_source", NULL, g_free);
+ update_copy_button (dialog);
+ return;
+ }
+
+ w = g_dbus_proxy_get_cached_property (proxy, "X11Variant");
+ if (w) {
+ variants = g_strsplit (g_variant_get_string (w, NULL), ",", -1);
+ g_object_set_data_full (G_OBJECT (label), "input_variants",
+ g_variant_dup_string (w, NULL), g_free);
+ g_variant_unref (w);
+ } else {
+ g_object_set_data_full (G_OBJECT (label), "input_variants", NULL, g_free);
+ }
+
+ if (variants && variants[0])
+ n = MIN (g_strv_length (layouts), g_strv_length (variants));
+ else
+ n = g_strv_length (layouts);
+
+ xkb_info = gnome_xkb_info_new ();
+ disp = g_string_new ("");
+ for (i = 0; i < n && layouts[i][0]; i++) {
+ const char *name;
+ char *id;
+
+ if (variants && variants[i] && variants[i][0])
+ id = g_strdup_printf ("%s+%s", layouts[i], variants[i]);
+ else
+ id = g_strdup (layouts[i]);
+
+ gnome_xkb_info_get_layout_info (xkb_info, id, &name, NULL, NULL, NULL);
+ if (disp->str[0] != '\0')
+ disp = g_string_append (disp, ", ");
+ disp = g_string_append (disp, name ? name : id);
+
+ g_free (id);
+ }
+ gtk_label_set_text (GTK_LABEL (label), disp->str);
+ g_string_free (disp, TRUE);
+
+ g_strfreev (variants);
+ g_strfreev (layouts);
+ g_object_unref (xkb_info);
+
update_copy_button (dialog);
}
@@ -296,6 +431,11 @@ copy_settings (GtkButton *button, GtkBuilder *dialog)
layout = g_object_get_data (G_OBJECT (label), "input_source");
variants = g_object_get_data (G_OBJECT (label), "input_variants");
+ if (layout == NULL || layout[0] == '\0') {
+ g_debug ("Not calling SetX11Keyboard, as there are no XKB input sources in the user's settings");
+ return;
+ }
+
g_dbus_proxy_call (localed_proxy,
"SetX11Keyboard",
g_variant_new ("(ssssbb)", layout, "", variants ? variants : "", "", TRUE, TRUE),
@@ -378,6 +518,11 @@ setup_system (GtkBuilder *dialog)
G_CALLBACK (locale_settings_changed), dialog);
g_object_weak_ref (G_OBJECT (dialog), (GWeakNotify) g_object_unref, locale_settings);
+ input_sources_settings = g_settings_new ("org.gnome.desktop.input-sources");
+ g_signal_connect (input_sources_settings, "changed::sources",
+ G_CALLBACK (input_sources_changed), dialog);
+ g_object_weak_ref (G_OBJECT (dialog), (GWeakNotify) g_object_unref, input_sources_settings);
+
/* Display user settings */
language = cc_common_language_get_current_language ();
system_update_language (dialog, language);
@@ -385,6 +530,8 @@ setup_system (GtkBuilder *dialog)
locale_settings_changed (locale_settings, "region", dialog);
+ input_sources_changed (input_sources_settings, "sources", dialog);
+
bus = g_bus_get_sync (G_BUS_TYPE_SYSTEM, NULL, NULL);
g_dbus_proxy_new (bus,
G_DBUS_PROXY_FLAGS_NONE,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]