[gnome-control-center] online-accounts: Remove unneeded signal	disconnections
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [gnome-control-center] online-accounts: Remove unneeded signal	disconnections
- Date: Tue, 25 Sep 2012 09:32:52 +0000 (UTC)
commit 4a993e753a898899a6cc05dbbcc222ef6fe5cbae
Author: Bastien Nocera <hadess hadess net>
Date:   Mon Sep 24 11:37:56 2012 +0200
    online-accounts: Remove unneeded signal disconnections
    
    Those signals will not be emitted anymore, as the objects that
    could emit them will be destroyed.
    
    Fixes a warning on exit, as panel->accounts_treeview is already
    destroyed when we get there.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684702
 panels/online-accounts/cc-online-accounts-panel.c |   16 ++--------------
 1 files changed, 2 insertions(+), 14 deletions(-)
---
diff --git a/panels/online-accounts/cc-online-accounts-panel.c b/panels/online-accounts/cc-online-accounts-panel.c
index fefb01e..b663b06 100644
--- a/panels/online-accounts/cc-online-accounts-panel.c
+++ b/panels/online-accounts/cc-online-accounts-panel.c
@@ -120,23 +120,11 @@ goa_panel_finalize (GObject *object)
 {
   GoaPanel *panel = GOA_PANEL (object);
 
-  g_signal_handlers_disconnect_by_func (gtk_tree_view_get_selection (GTK_TREE_VIEW (panel->accounts_treeview)),
-                                        G_CALLBACK (on_tree_view_selection_changed),
-                                        panel);
   if (panel->accounts_model != NULL)
-    {
-      g_signal_handlers_disconnect_by_func (panel->accounts_model, G_CALLBACK (on_model_row_deleted), panel);
-      g_signal_handlers_disconnect_by_func (panel->accounts_model, G_CALLBACK (on_model_row_inserted), panel);
-      g_clear_object (&panel->accounts_model);
-    }
+    g_clear_object (&panel->accounts_model);
 
   if (panel->client != NULL)
-    {
-      g_signal_handlers_disconnect_by_func (panel->client,
-                                            G_CALLBACK (on_account_changed),
-                                            panel);
-      g_object_unref (panel->client);
-    }
+    g_object_unref (panel->client);
   g_object_unref (panel->builder);
 
   G_OBJECT_CLASS (goa_panel_parent_class)->finalize (object);
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]