[glom] Deal with more minor TODOs



commit aef10a045ed3fd6d76222581e20614b81c8a7a6a
Author: Murray Cumming <murrayc murrayc com>
Date:   Mon Apr 1 21:00:02 2013 +0200

    Deal with more minor TODOs

 glom/bakery/dialog_offersave.cc                    |    5 ++++-
 glom/libglom/data_structure/fieldtypes.cc          |    2 +-
 glom/libglom/data_structure/glomconversions.cc     |    4 ++--
 .../data_structure/layout/layoutitem_line.h        |    6 +++++-
 glom/libglom/data_structure/system_prefs.h         |    2 +-
 5 files changed, 13 insertions(+), 6 deletions(-)
---
diff --git a/glom/bakery/dialog_offersave.cc b/glom/bakery/dialog_offersave.cc
index 78b858e..eb420f8 100644
--- a/glom/bakery/dialog_offersave.cc
+++ b/glom/bakery/dialog_offersave.cc
@@ -32,7 +32,10 @@ namespace
     if(!file_uri.empty())
     {
       message += "\n\n";
-      message += Glib::ustring::compose(_("Document:\n%1"), Glib::filename_display_basename(file_uri)); 
//TODO: Can we use filename_display_basename() with a URI?
+
+      //TODO: Can we use filename_display_basename() with a URI?
+      // No, almost certainly not. murrayc.
+      message += Glib::ustring::compose(_("Document:\n%1"), Glib::filename_display_basename(file_uri));
     }
 
     return message;
diff --git a/glom/libglom/data_structure/fieldtypes.cc b/glom/libglom/data_structure/fieldtypes.cc
index 24ea765..d81c9df 100644
--- a/glom/libglom/data_structure/fieldtypes.cc
+++ b/glom/libglom/data_structure/fieldtypes.cc
@@ -86,7 +86,7 @@ FieldTypes::FieldTypes(const Glib::RefPtr<Gnome::Gda::Connection>& gda_connectio
             //std::cout << "debug: schema_type_string=" << schema_type_string << ", gda type=" << gdatype << 
"(" << g_type_name(gdatype) << ")" << std::endl;
 
             //Save it for later:
-            const Glib::ustring gdatypestring = gda_g_type_to_string(gdatype); // TODO: What is this 
actually used for?
+            //const Glib::ustring gdatypestring = gda_g_type_to_string(gdatype);
            
             //std::cout << "schema type: " << schema_type_string << " = gdatype " << (guint)gdatype << "(" 
<< gdatypestring << ")" << std::endl;
             
diff --git a/glom/libglom/data_structure/glomconversions.cc b/glom/libglom/data_structure/glomconversions.cc
index 7039ce8..8f96442 100644
--- a/glom/libglom/data_structure/glomconversions.cc
+++ b/glom/libglom/data_structure/glomconversions.cc
@@ -322,8 +322,8 @@ double Conversions::get_double_for_gda_value_numeric(const Gnome::Gda::Value& va
         return value.get_int();
       case G_TYPE_UINT:
         return value.get_uint();
-      //case G_TYPE_LONG:
-      //TODO: Add this to libgdamm:  return value.get_long();
+      case G_TYPE_LONG:
+        return value.get_long();
       case G_TYPE_ULONG:
         return value.get_ulong();
       case G_TYPE_INT64:
diff --git a/glom/libglom/data_structure/layout/layoutitem_line.h 
b/glom/libglom/data_structure/layout/layoutitem_line.h
index 10d982e..65eee2b 100644
--- a/glom/libglom/data_structure/layout/layoutitem_line.h
+++ b/glom/libglom/data_structure/layout/layoutitem_line.h
@@ -55,8 +55,12 @@ public:
   double get_line_width() const;
   void set_line_width(double line_width);
   
-  //TODO: Document the format:
+  /** Get the line color in CSS3 format.
+   */
   Glib::ustring get_line_color() const;
+
+  /** Set the line color in CSS3 format.
+   */
   void set_line_color(const Glib::ustring& color);
 
 private:
diff --git a/glom/libglom/data_structure/system_prefs.h b/glom/libglom/data_structure/system_prefs.h
index 0317856..748f5e4 100644
--- a/glom/libglom/data_structure/system_prefs.h
+++ b/glom/libglom/data_structure/system_prefs.h
@@ -39,7 +39,7 @@ public:
   bool operator!=(const SystemPrefs& src) const;
  
 
- //TODO: Add getters and setters:
+  //TODO: Add getters and setters:
   Glib::ustring m_name, m_org_name,
     m_org_address_street, m_org_address_street2, m_org_address_town, 
     m_org_address_county, m_org_address_country, m_org_address_postcode;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]