[gupnp] Clarify notification SEQ count behavior
- From: Jens Georg <jensgeorg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gupnp] Clarify notification SEQ count behavior
- Date: Wed, 17 Apr 2013 09:03:57 +0000 (UTC)
commit 76502171a2a9d882fe25edfe66cd6395d640b338
Author: Jens Georg <mail jensge org>
Date: Wed Apr 17 11:02:25 2013 +0200
Clarify notification SEQ count behavior
libgupnp/gupnp-service-proxy.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
---
diff --git a/libgupnp/gupnp-service-proxy.c b/libgupnp/gupnp-service-proxy.c
index 69b345b..691ec7e 100644
--- a/libgupnp/gupnp-service-proxy.c
+++ b/libgupnp/gupnp-service-proxy.c
@@ -1760,13 +1760,19 @@ emit_notifications (gpointer user_data)
emit_notify_data = pending_notify->data;
if (emit_notify_data->seq > proxy->priv->seq) {
- /* Oops, we missed a notify. Resubscribe .. */
+ /* Error procedure on missed event according to
+ * UDA 1.0, section 4.2, §5:
+ * Re-subscribe to get a new SID and SEQ */
resubscribe = TRUE;
break;
}
/* Increment our own event sequence number */
+ /* UDA 1.0, section 4.2, §3: To prevent overflow, SEQ is set to
+ * 1, NOT 0, when encountering G_MAXUINT32. SEQ == 0 always
+ * indicates the initial event message.
+ * FIXME: bgo#698125 */
if (proxy->priv->seq < G_MAXINT32)
proxy->priv->seq++;
else
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]