[gtk+/gtk-2-24] entry: unset the completion in dispose() not finalize()



commit ba5ac33cdc18fe252de9baac6a2927f9ea77e6ab
Author: Michael Natterer <mitch gimp org>
Date:   Sun Apr 21 05:09:52 2013 +0200

    entry: unset the completion in dispose() not finalize()
    
    Most likely fixes whatever evil gail interaction causing a crash I
    could never reproduce but has been reported several times against GIMP.
    The same fix is in GTK+ 3.x already (bug #683983).

 gtk/gtkentry.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/gtk/gtkentry.c b/gtk/gtkentry.c
index 2c9c5a4..9f5350f 100644
--- a/gtk/gtkentry.c
+++ b/gtk/gtkentry.c
@@ -2471,6 +2471,7 @@ gtk_entry_dispose (GObject *object)
   gtk_entry_set_icon_tooltip_markup (entry, GTK_ENTRY_ICON_PRIMARY, NULL);
   gtk_entry_set_icon_from_pixbuf (entry, GTK_ENTRY_ICON_SECONDARY, NULL);
   gtk_entry_set_icon_tooltip_markup (entry, GTK_ENTRY_ICON_SECONDARY, NULL);
+  gtk_entry_set_completion (entry, NULL);
 
   if (priv->buffer)
     {
@@ -2505,8 +2506,6 @@ gtk_entry_finalize (GObject *object)
         }
     }
 
-  gtk_entry_set_completion (entry, NULL);
-
   if (entry->cached_layout)
     g_object_unref (entry->cached_layout);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]