[gnome-shell] network: Remove some genericism in the wireless code
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] network: Remove some genericism in the wireless code
- Date: Fri, 26 Apr 2013 16:25:09 +0000 (UTC)
commit 7a8b392607db3f0fa2d9e154ca375e1b868936b0
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Thu Apr 25 17:20:57 2013 -0400
network: Remove some genericism in the wireless code
This was presumably originally used in multiple places, but it's
not anymore, so un-generify the code here.
https://bugzilla.gnome.org/show_bug.cgi?id=698918
js/ui/status/network.js | 30 ++++++++++++------------------
1 files changed, 12 insertions(+), 18 deletions(-)
---
diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 8a9292a..5852fcf 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -130,18 +130,12 @@ const NMWirelessSectionTitleMenuItem = new Lang.Class({
Name: 'NMWirelessSectionTitleMenuItem',
Extends: PopupMenu.PopupSwitchMenuItem,
- _init: function(client, property, title, params) {
- params = params || { };
- params.style_class = 'popup-subtitle-menu-item';
- this.parent(title, false, params);
+ _init: function(client) {
+ this.parent(_("Wi-Fi"), false, { style_class: 'popup-subtitle-menu-item' });
this._client = client;
- this._property = property + '_enabled';
- this._propertyHardware = property + '_hardware_enabled';
- this._setEnabledFunc = property + '_set_enabled';
-
- this._client.connect('notify::' + property + '-enabled', Lang.bind(this, this._propertyChanged));
- this._client.connect('notify::' + property + '-hardware-enabled', Lang.bind(this,
this._propertyChanged));
+ this._client.connect('notify::wireless-enabled', Lang.bind(this, this._propertyChanged));
+ this._client.connect('notify::wireless-hardware-enabled', Lang.bind(this, this._propertyChanged));
this._propertyChanged();
},
@@ -163,12 +157,12 @@ const NMWirelessSectionTitleMenuItem = new Lang.Class({
activate: function(event) {
this.parent(event);
- this._client[this._setEnabledFunc](this._switch.state);
+ this._client.wireless_set_enabled(this._switch.state);
},
_propertyChanged: function() {
- this._softwareEnabled = this._client[this._property];
- this._hardwareEnabled = this._client[this._propertyHardware];
+ this._softwareEnabled = this._client.wireless_enabled;
+ this._hardwareEnabled = this._client.wireless_hardware_enabled;
let enabled = this._softwareEnabled && this._hardwareEnabled;
this.setToggleState(enabled);
@@ -1641,7 +1635,7 @@ const NMApplet = new Lang.Class({
this._devices.wireless = {
section: new PopupMenu.PopupMenuSection(),
devices: [ ],
- item: this._makeToggleItem('wireless', _("Wi-Fi"))
+ item: this._makeWirelessToggle()
};
this._devices.wireless.section.addMenuItem(this._devices.wireless.item);
this._devices.wireless.section.actor.hide();
@@ -1688,14 +1682,14 @@ const NMApplet = new Lang.Class({
}
},
- _makeToggleItem: function(type, title) {
- let item = new NMWirelessSectionTitleMenuItem(this._client, type, title);
+ _makeWirelessToggle: function() {
+ let item = new NMWirelessSectionTitleMenuItem(this._client);
item.connect('enabled-changed', Lang.bind(this, function(item, enabled) {
- let devices = this._devices[type].devices;
+ let devices = this._devices.wireless.devices;
devices.forEach(function(dev) {
dev.setEnabled(enabled);
});
- this._syncSectionTitle(type);
+ this._syncSectionTitle('wireless');
}));
return item;
},
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]