[gnome-initial-setup] goa: Disconnect network monitor on dispose
- From: Colin Walters <walters src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [gnome-initial-setup] goa: Disconnect network monitor on dispose
 
- Date: Tue, 30 Apr 2013 17:55:21 +0000 (UTC)
 
commit b11f9a6239e03e3d57c0b7fec6ae61912fe61c63
Author: Colin Walters <walters verbum org>
Date:   Tue Apr 30 13:51:33 2013 -0400
    goa: Disconnect network monitor on dispose
    
    Otherwise if the network changes we can call back into freed data,
    causing Bad Things(tm).
 gnome-initial-setup/pages/goa/gis-goa-page.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/gnome-initial-setup/pages/goa/gis-goa-page.c b/gnome-initial-setup/pages/goa/gis-goa-page.c
index af1c2b3..2ac8573 100644
--- a/gnome-initial-setup/pages/goa/gis-goa-page.c
+++ b/gnome-initial-setup/pages/goa/gis-goa-page.c
@@ -377,9 +377,12 @@ gis_goa_page_dispose (GObject *object)
 {
   GisGoaPage *page = GIS_GOA_PAGE (object);
   GisGoaPagePrivate *priv = page->priv;
+  GNetworkMonitor *network_monitor = g_network_monitor_get_default ();
 
   g_clear_object (&priv->goa_client);
 
+  g_signal_handlers_disconnect_by_func (network_monitor, G_CALLBACK (network_status_changed), page);
+
   G_OBJECT_CLASS (gis_goa_page_parent_class)->dispose (object);
 }
 
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]