[sound-juicer] Replace stock icons with named icons
- From: Phillip Wood <pwood src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [sound-juicer] Replace stock icons with named icons
- Date: Tue, 20 Aug 2013 09:49:10 +0000 (UTC)
commit 50c4b53d917271dcbe8afe9138149a009132ed33
Author: Phillip Wood <phillip wood dunelm org uk>
Date: Wed Jul 24 18:28:01 2013 +0100
Replace stock icons with named icons
This works around GTK bug #702423 which stops the playback icon showing
on GTK 3.8 & later. This is also a small first step towards removing
deprecated stock items.
https://bugzilla.gnome.org/show_bug.cgi?id=705131
src/sj-main.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
---
diff --git a/src/sj-main.c b/src/sj-main.c
index a91be5a..ea67637 100644
--- a/src/sj-main.c
+++ b/src/sj-main.c
@@ -322,16 +322,20 @@ static void number_cell_icon_data_cb (GtkTreeViewColumn *tree_column,
gtk_tree_model_get (tree_model, iter, COLUMN_STATE, &state, -1);
switch (state) {
case STATE_IDLE:
- g_object_set (G_OBJECT (cell), "stock-id", NULL, NULL);
+ g_object_set (G_OBJECT (cell), "icon-name", NULL, NULL);
break;
case STATE_PLAYING:
- g_object_set (G_OBJECT (cell), "stock-id", GTK_STOCK_MEDIA_PLAY, NULL);
+ {
+ gboolean rtl = gtk_widget_get_direction (track_listview) == GTK_TEXT_DIR_RTL;
+ gchar *name = rtl ? "media-playback-start-rtl" : "media-playback-start";
+ g_object_set (G_OBJECT (cell), "icon-name", name, NULL);
+ }
break;
case STATE_PAUSED:
- g_object_set (G_OBJECT (cell), "stock-id", GTK_STOCK_MEDIA_PAUSE, NULL);
+ g_object_set (G_OBJECT (cell), "icon-name", "media-playback-pause", NULL);
break;
case STATE_EXTRACTING:
- g_object_set (G_OBJECT (cell), "stock-id", GTK_STOCK_MEDIA_RECORD, NULL);
+ g_object_set (G_OBJECT (cell), "icon-name", "media-record", NULL);
break;
default:
g_warning("Unhandled track state %d\n", state);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]