[gnome-desktop-testing] runner: If we catch an unexpected exception, correctly show error and terminate
- From: Colin Walters <walters src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-desktop-testing] runner: If we catch an unexpected exception, correctly show error and terminate
- Date: Tue, 20 Aug 2013 23:36:58 +0000 (UTC)
commit 133ca683c9a5a262c9c13d8e97f211b0a90c1c28
Author: Colin Walters <walters verbum org>
Date: Tue Aug 20 19:35:55 2013 -0400
runner: If we catch an unexpected exception, correctly show error and terminate
If for example a test file has a bad Exec= line and we can't even
start the test, the intention was that the runner exits abnormally.
But due to a missing "goto out" we were exiting early, but not logging
an error.
src/gnome-desktop-testing-runner.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/src/gnome-desktop-testing-runner.c b/src/gnome-desktop-testing-runner.c
index 8a396b2..3fe430a 100755
--- a/src/gnome-desktop-testing-runner.c
+++ b/src/gnome-desktop-testing-runner.c
@@ -667,7 +667,10 @@ main (int argc, char **argv)
g_main_context_iteration (NULL, TRUE);
if (app->test_error)
- g_propagate_error (error, app->test_error);
+ {
+ g_propagate_error (error, app->test_error);
+ goto out;
+ }
}
ret = TRUE;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]