[gnome-packagekit/gnome-3-8] Swapped "Required packages" and "Dependent packages" button functionality.
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-packagekit/gnome-3-8] Swapped "Required packages" and "Dependent packages" button functionality.
- Date: Thu, 22 Aug 2013 12:08:22 +0000 (UTC)
commit a38cfe71f14427520cf38b4c1e67d315374201e9
Author: Ignaker <ignaker gmail com>
Date: Thu Aug 22 02:50:58 2013 +0200
Swapped "Required packages" and "Dependent packages" button functionality.
Button's functionality were reversed.
Swapped pk_client_get_requires_async with pk_client_get_depends_async
function call. Added prototypes for callbacks that now are swapped too.
https://bugzilla.gnome.org/show_bug.cgi?id=692629
src/gpk-application.c | 17 +++++++++++++----
1 files changed, 13 insertions(+), 4 deletions(-)
---
diff --git a/src/gpk-application.c b/src/gpk-application.c
index fe9cd0d..2ce1cf6 100644
--- a/src/gpk-application.c
+++ b/src/gpk-application.c
@@ -130,6 +130,9 @@ enum {
static void gpk_application_perform_search (GpkApplicationPrivate *priv);
+static void gpk_application_get_requires_cb (PkClient *client, GAsyncResult *res, GpkApplicationPrivate
*priv);
+static void gpk_application_get_depends_cb (PkClient *client, GAsyncResult *res, GpkApplicationPrivate
*priv);
+
/**
* gpk_application_state_get_icon:
**/
@@ -959,11 +962,14 @@ gpk_application_menu_requires_cb (GtkAction *action, GpkApplicationPrivate *priv
/* get the requires */
package_ids = pk_package_ids_from_id (package_id_selected);
- pk_client_get_requires_async (PK_CLIENT (priv->task),
+
+ /* pk_client_get_depends/requires semantic is reversed */
+ pk_client_get_depends_async (PK_CLIENT (priv->task),
pk_bitfield_value (PK_FILTER_ENUM_NONE),
package_ids, TRUE, priv->cancellable,
(PkProgressCallback) gpk_application_progress_cb, priv,
- (GAsyncReadyCallback) gpk_application_get_requires_cb, priv);
+ (GAsyncReadyCallback) gpk_application_get_depends_cb, priv);
+
out:
g_free (package_id_selected);
g_strfreev (package_ids);
@@ -1081,11 +1087,14 @@ gpk_application_menu_depends_cb (GtkAction *_action, GpkApplicationPrivate *priv
/* get the depends */
package_ids = pk_package_ids_from_id (package_id_selected);
- pk_client_get_depends_async (PK_CLIENT (priv->task),
+
+ /* pk_client_get_depends/require semantic is reversed */
+ pk_client_get_requires_async (PK_CLIENT (priv->task),
pk_bitfield_value (PK_FILTER_ENUM_NONE),
package_ids, TRUE, priv->cancellable,
(PkProgressCallback) gpk_application_progress_cb, priv,
- (GAsyncReadyCallback) gpk_application_get_depends_cb, priv);
+ (GAsyncReadyCallback) gpk_application_get_requires_cb, priv);
+
out:
g_free (package_id_selected);
g_strfreev (package_ids);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]