[dia] [scan-build] fix unintended self assignment
- From: Hans Breuer <hans src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [dia] [scan-build] fix unintended self assignment
- Date: Sun, 25 Aug 2013 10:00:38 +0000 (UTC)
commit 973c8b62dd964c21fef64ed3e8114123f811a4a4
Author: Hans Breuer <hans breuer org>
Date: Sun Aug 25 11:53:37 2013 +0200
[scan-build] fix unintended self assignment
The alias should use the same icon as it's target IIRC.
lib/object-alias.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/lib/object-alias.c b/lib/object-alias.c
index faa0498..ca05c9f 100644
--- a/lib/object-alias.c
+++ b/lib/object-alias.c
@@ -171,12 +171,12 @@ object_register_alias_type (DiaObjectType *type, ObjectNode alias_node)
alias_type->name = g_strdup ((char *)name);
alias_type->ops = &_alias_type_ops;
alias_type->version = type->version; /* really? */
- alias_type->pixmap = alias_type->pixmap;
+ alias_type->pixmap = type->pixmap;
alias_type->pixmap_file = type->pixmap_file ;
alias_type->default_user_data = alias_type; /* _create has no self pointer */
object_register_type (alias_type);
-
+
if (!_alias_types_ht)
_alias_types_ht = g_hash_table_new (g_str_hash, g_str_equal);
g_hash_table_insert (_alias_types_ht, g_strdup ((char *)name), type);
@@ -184,3 +184,4 @@ object_register_alias_type (DiaObjectType *type, ObjectNode alias_node)
xmlFree (name);
}
}
+
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]