[mutter] idle-monitor: Fix a warning when a callback removes the user active watch

[Jasper St. Pierre <jstpierre src gnome org>]

commit 576cd87a5bc7d5abe22d1d20b00f4ace13dde050
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Mon Aug 26 16:22:08 2013 -0400

    idle-monitor: Fix a warning when a callback removes the user active watch
    
    The user active watch is a one-fire watch, but it is valid in the API
    for the callback to explicitly remove the watch itself. In that case,
    the watch will be invalid after the user removes it, and the memory
    potentially freed. So make sure to not dereference the watch after
    the callback is called.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706825

 src/core/meta-idle-monitor.c |   17 +++++++++--------
 1 files changed, 9 insertions(+), 8 deletions(-)
---
diff --git a/src/core/meta-idle-monitor.c b/src/core/meta-idle-monitor.c
index 568e6db..0d841c4 100644
--- a/src/core/meta-idle-monitor.c
+++ b/src/core/meta-idle-monitor.c
@@ -104,19 +104,20 @@ static void
 fire_watch (MetaIdleMonitorWatch *watch)
 {
   MetaIdleMonitor *monitor;
+  guint id;
+  gboolean is_user_active_watch;
 
   monitor = watch->monitor;
   g_object_ref (monitor);
 
+  id = watch->id;
+  is_user_active_watch = (watch->timeout_msec == 0);
+
   if (watch->callback)
-    {
-      watch->callback (watch->monitor,
-                       watch->id,
-                       watch->user_data);
-    }
+    watch->callback (monitor, id, watch->user_data);
 
-  if (watch->timeout_msec == 0)
-    meta_idle_monitor_remove_watch (watch->monitor, watch->id);
+  if (is_user_active_watch)
+    meta_idle_monitor_remove_watch (monitor, id);
 
   g_object_unref (monitor);
 }