[grilo-plugins] flickr: Do not convert "id" to number
- From: Juan A. Suarez Romero <jasuarez src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [grilo-plugins] flickr: Do not convert "id" to number
- Date: Wed, 28 Aug 2013 08:13:17 +0000 (UTC)
commit 9ef8cd1210130554167974561fa4dd652d5ffe4d
Author: Juan A. Suarez Romero <jasuarez igalia com>
Date: Wed Aug 28 08:09:37 2013 +0000
flickr: Do not convert "id" to number
We don't need to convert it to a number; we can deal with it as a string.
This also fixes problems with invalid conversions or numbers outside range.
https://bugzilla.gnome.org/show_bug.cgi?id=706917
src/flickr/gflickr.c | 4 ++--
src/flickr/gflickr.h | 2 +-
src/flickr/grl-flickr.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/flickr/gflickr.c b/src/flickr/gflickr.c
index 9285aeb..6d88d11 100644
--- a/src/flickr/gflickr.c
+++ b/src/flickr/gflickr.c
@@ -503,7 +503,7 @@ g_flickr_set_per_page (GFlickr *f, gint per_page)
void
g_flickr_photos_getInfo (GFlickr *f,
- glong photo_id,
+ const gchar *photo_id,
GFlickrHashTableCb callback,
gpointer user_data)
{
@@ -511,7 +511,7 @@ g_flickr_photos_getInfo (GFlickr *f,
gchar *params[2];
- params[0] = g_strdup_printf ("photo_id=%ld", photo_id);
+ params[0] = g_strdup_printf ("photo_id=%s", photo_id);
params[1] = g_strdup_printf ("method=%s", FLICKR_PHOTOS_GETINFO_METHOD);
gchar *request = create_url (f, params, 2);
diff --git a/src/flickr/gflickr.h b/src/flickr/gflickr.h
index ffe5927..31b28ac 100644
--- a/src/flickr/gflickr.h
+++ b/src/flickr/gflickr.h
@@ -91,7 +91,7 @@ void g_flickr_set_per_page (GFlickr *f, gint per_page);
void
g_flickr_photos_getInfo (GFlickr *f,
- glong photo_id,
+ const gchar *photo_id,
GFlickrHashTableCb callback,
gpointer user_data);
diff --git a/src/flickr/grl-flickr.c b/src/flickr/grl-flickr.c
index 651efe8..f359c01 100644
--- a/src/flickr/grl-flickr.c
+++ b/src/flickr/grl-flickr.c
@@ -974,7 +974,7 @@ grl_flickr_source_resolve (GrlSource *source,
}
g_flickr_photos_getInfo (GRL_FLICKR_SOURCE (source)->priv->flickr,
- atol (id),
+ id,
getInfo_cb,
rs);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]