[gnome-software] Don't grab focus back to the search entry
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] Don't grab focus back to the search entry
- Date: Fri, 30 Aug 2013 04:15:12 +0000 (UTC)
commit e1d8a93afa2ce2c0912c3d6363dd08f5e7732ec6
Author: Matthias Clasen <mclasen redhat com>
Date: Fri Aug 30 00:13:09 2013 -0400
Don't grab focus back to the search entry
This is actually counter-productive, as it selects the entry
contents, so if you are in the middle of typing something,
the text gets selected and then your next key press overwrites
it.
src/gs-shell-overview.c | 4 ----
src/gs-shell-search.c | 3 ---
src/gs-shell-updates.c | 3 ---
3 files changed, 0 insertions(+), 10 deletions(-)
---
diff --git a/src/gs-shell-overview.c b/src/gs-shell-overview.c
index 07f0ba6..9a986d0 100644
--- a/src/gs-shell-overview.c
+++ b/src/gs-shell-overview.c
@@ -209,7 +209,6 @@ gs_shell_overview_get_featured_cb (GObject *source_object,
GsPluginLoader *plugin_loader = GS_PLUGIN_LOADER (source_object);
GtkImage *image;
GtkWidget *button;
- GtkWidget *widget;
list = gs_plugin_loader_get_featured_finish (plugin_loader,
res,
@@ -230,9 +229,6 @@ gs_shell_overview_get_featured_cb (GObject *source_object,
g_signal_connect (button, "clicked",
G_CALLBACK (app_tile_clicked), shell_overview);
- /* focus back to the text extry */
- widget = GTK_WIDGET (gtk_builder_get_object (priv->builder, "entry_search"));
- gtk_widget_grab_focus (widget);
out:
g_list_free (list);
diff --git a/src/gs-shell-search.c b/src/gs-shell-search.c
index fa81fba..d120fea 100644
--- a/src/gs-shell-search.c
+++ b/src/gs-shell-search.c
@@ -246,9 +246,6 @@ gs_shell_search_get_search_cb (GObject *source_object,
gtk_widget_show (widget);
}
- /* focus back to the text extry */
- widget = GTK_WIDGET (gtk_builder_get_object (priv->builder, "entry_search"));
- gtk_widget_grab_focus (widget);
out: ;
}
diff --git a/src/gs-shell-updates.c b/src/gs-shell-updates.c
index 3dffa2c..1745bbe 100644
--- a/src/gs-shell-updates.c
+++ b/src/gs-shell-updates.c
@@ -116,9 +116,6 @@ gs_shell_updates_get_updates_cb (GsPluginLoader *plugin_loader,
gtk_widget_show (widget);
}
- /* focus back to the text extry */
- widget = GTK_WIDGET (gtk_builder_get_object (priv->builder, "entry_search"));
- gtk_widget_grab_focus (widget);
out:
if (list != NULL)
g_list_free_full (list, (GDestroyNotify) g_object_unref);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]