[grilo-plugins] lastfm-albumart: Do not return default image
- From: Juan A. Suarez Romero <jasuarez src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [grilo-plugins] lastfm-albumart: Do not return default image
- Date: Thu, 14 Feb 2013 17:18:16 +0000 (UTC)
commit 694cd710d3f8c07a35624cbadb6969d0a1d40920
Author: Juan A. Suarez Romero <jasuarez igalia com>
Date: Thu Feb 14 17:14:00 2013 +0000
lastfm-albumart: Do not return default image
When Last.fm does not recognize an album, it returns a default image to be used
as the thumbnail. This prevents other sources to take the chance to try to
provide a real thumbnail.
Do not return a default thumbnail if the source can not solve it, and let other
sources to try it.
src/lastfm-albumart/grl-lastfm-albumart.c | 22 ++++++++++++----------
1 files changed, 12 insertions(+), 10 deletions(-)
---
diff --git a/src/lastfm-albumart/grl-lastfm-albumart.c b/src/lastfm-albumart/grl-lastfm-albumart.c
index 23ef72f..1b9eb2e 100644
--- a/src/lastfm-albumart/grl-lastfm-albumart.c
+++ b/src/lastfm-albumart/grl-lastfm-albumart.c
@@ -42,6 +42,8 @@ GRL_LOG_DOMAIN_STATIC(lastfm_albumart_log_domain);
#define LASTFM_GET_ALBUM "http://ws.audioscrobbler.com/1.0/album/%s/%s/info.xml"
+#define LASTFM_DEFAULT_IMAGE "http://cdn.last.fm/flatness/catalogue/noimage/2/default_album_medium.png"
+
#define LASTFM_XML_COVER_MEDIUM "/album/coverart/medium"
#define LASTFM_XML_COVER_LARGE "/album/coverart/large"
#define LASTFM_XML_COVER_SMALL "/album/coverart/small"
@@ -230,44 +232,44 @@ read_done_cb (GObject *source_object,
}
image = xml_get_image (content, LASTFM_XML_COVER_MEGA);
- if (image) {
+ if (image && g_strcmp0 (image, LASTFM_DEFAULT_IMAGE) != 0) {
relkeys = grl_related_keys_new_with_keys (GRL_METADATA_KEY_THUMBNAIL, image,
NULL);
grl_data_add_related_keys (GRL_DATA (rs->media), relkeys);
- g_free (image);
}
+ g_free (image);
image = xml_get_image (content, LASTFM_XML_COVER_EXTRA);
- if (image) {
+ if (image && g_strcmp0 (image, LASTFM_DEFAULT_IMAGE) != 0) {
relkeys = grl_related_keys_new_with_keys (GRL_METADATA_KEY_THUMBNAIL, image,
NULL);
grl_data_add_related_keys (GRL_DATA (rs->media), relkeys);
- g_free (image);
}
+ g_free (image);
image = xml_get_image (content, LASTFM_XML_COVER_LARGE);
- if (image) {
+ if (image && g_strcmp0 (image, LASTFM_DEFAULT_IMAGE) != 0) {
relkeys = grl_related_keys_new_with_keys (GRL_METADATA_KEY_THUMBNAIL, image,
NULL);
grl_data_add_related_keys (GRL_DATA (rs->media), relkeys);
- g_free (image);
}
+ g_free (image);
image = xml_get_image (content, LASTFM_XML_COVER_MEDIUM);
- if (image) {
+ if (image && g_strcmp0 (image, LASTFM_DEFAULT_IMAGE) != 0) {
relkeys = grl_related_keys_new_with_keys (GRL_METADATA_KEY_THUMBNAIL, image,
NULL);
grl_data_add_related_keys (GRL_DATA (rs->media), relkeys);
- g_free (image);
}
+ g_free (image);
image = xml_get_image (content, LASTFM_XML_COVER_SMALL);
- if (image) {
+ if (image && g_strcmp0 (image, LASTFM_DEFAULT_IMAGE) != 0) {
relkeys = grl_related_keys_new_with_keys (GRL_METADATA_KEY_THUMBNAIL, image,
NULL);
grl_data_add_related_keys (GRL_DATA (rs->media), relkeys);
- g_free (image);
}
+ g_free (image);
rs->callback (rs->source, rs->operation_id, rs->media, rs->user_data, NULL);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]