[easytag] Fix a couple of memory leaks in the CDDB search
- From: David King <davidk src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [easytag] Fix a couple of memory leaks in the CDDB search
- Date: Thu, 14 Feb 2013 23:12:27 +0000 (UTC)
commit 4d5cdd7dab803dd37da7ba89bac146aec49792e9
Author: David King <amigadave amigadave com>
Date: Thu Feb 14 23:11:36 2013 +0000
Fix a couple of memory leaks in the CDDB search
src/cddb.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/src/cddb.c b/src/cddb.c
index b31385e..305d804 100644
--- a/src/cddb.c
+++ b/src/cddb.c
@@ -1832,10 +1832,13 @@ Cddb_Read_Http_Header (FILE **file, gchar **cddb_out)
if ( !*cddb_out || strncmp("HTTP",*cddb_out,4)!=0 || strstr(*cddb_out,"200 OK")==NULL )
return -1;
- // Read until end of the http header up to the next blank line
- while ( Cddb_Read_Line(file,cddb_out) > 0 && *cddb_out && strlen(*cddb_out) > 0 )
+ /* Read until end of the HTTP header up to the next blank line. */
+ do
{
+ g_free (*cddb_out);
}
+ while (Cddb_Read_Line (file, cddb_out) > 0
+ && *cddb_out && strlen (*cddb_out) > 0);
//g_print("Http Header : %s\n",*cddb_out);
return 1;
@@ -3199,7 +3202,10 @@ Cddb_Search_Album_From_Selected_Files (void)
* will be a single '.'
*/
if ( cddb_out_tmp && strlen(cddb_out_tmp)<=3 && strstr(cddb_out_tmp,cddb_end_str)!=NULL )
+ {
+ g_free (cddb_out);
break;
+ }
// Compatibility for the MusicBrainz CddbGateway
if ( cddb_out_tmp && strlen(cddb_out_tmp)>3
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]