[evolution] Bug #674236 - Extra ref in e_action_combo_box_set_action()
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution] Bug #674236 - Extra ref in e_action_combo_box_set_action()
- Date: Tue, 19 Feb 2013 12:18:10 +0000 (UTC)
commit 685e763c6ac8923cbf8af5c5c84d441ee2df7db5
Author: Milan Crha <mcrha redhat com>
Date: Tue Feb 19 13:17:35 2013 +0100
Bug #674236 - Extra ref in e_action_combo_box_set_action()
e-util/e-action-combo-box.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/e-util/e-action-combo-box.c b/e-util/e-action-combo-box.c
index cb15d27..0b7a31c 100644
--- a/e-util/e-action-combo-box.c
+++ b/e-util/e-action-combo-box.c
@@ -490,10 +490,12 @@ e_action_combo_box_set_action (EActionComboBox *combo_box,
combo_box->priv->action_group = NULL;
}
- if (action != NULL)
+ if (action != NULL) {
+ /* This also adds a reference to the combo_box->priv->action_group */
g_object_get (
g_object_ref (action), "action-group",
&combo_box->priv->action_group, NULL);
+ }
combo_box->priv->action = action;
action_combo_box_update_model (combo_box);
@@ -505,7 +507,6 @@ e_action_combo_box_set_action (EActionComboBox *combo_box,
combo_box);
if (combo_box->priv->action_group != NULL) {
- g_object_ref (combo_box->priv->action_group);
combo_box->priv->group_sensitive_handler_id =
g_signal_connect (
combo_box->priv->action_group,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]