[gnome-shell] xdnd: Don't wait for the stage to be disabled when it is already visible
- From: Adel Gadllah <agadllah src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] xdnd: Don't wait for the stage to be disabled when it is already visible
- Date: Fri, 22 Feb 2013 18:37:54 +0000 (UTC)
commit f644bee83195f7d094ed75e8d8e2b414be39cc96
Author: Adel Gadllah <adel gadllah gmail com>
Date: Fri Feb 22 19:26:17 2013 +0100
xdnd: Don't wait for the stage to be disabled when it is already visible
xdndHandler used to wait for the stage to show up before calling
global.init_xdnd() . Since commit 65303d027aa8 xdndHandler is initalized
later so the stage might be already visible at this point causing the
show signal never to be emitted and thus global.init_xdnd will never
be called.
Fix that by checking by calling global.init_xdnd without waiting for
the stage's show signal to be emitted, as the stage is guaranted to be
visible at this point.
js/ui/xdndHandler.js | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
---
diff --git a/js/ui/xdndHandler.js b/js/ui/xdndHandler.js
index ee52335..a662b44 100644
--- a/js/ui/xdndHandler.js
+++ b/js/ui/xdndHandler.js
@@ -21,14 +21,7 @@ const XdndHandler = new Lang.Class({
Shell.util_set_hidden_from_pick(this._dummy, true);
this._dummy.hide();
- // Mutter delays the creation of the output window as long
- // as possible to avoid flicker. In case a plugin wants to
- // access it directly it has to connect to the stage's show
- // signal. (see comment in compositor.c:meta_compositor_manage_screen)
- global.stage.connect('show', function () {
- global.init_xdnd();
- return false;
- });
+ global.init_xdnd();
global.connect('xdnd-enter', Lang.bind(this, this._onEnter));
global.connect('xdnd-position-changed', Lang.bind(this, this._onPositionChanged));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]