[network-manager-applet] applet: fix crash when using MM1 in mobile broadband PIN dialog
- From: Dan Williams <dcbw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-applet] applet: fix crash when using MM1 in mobile broadband PIN dialog
- Date: Thu, 28 Feb 2013 17:10:10 +0000 (UTC)
commit c452fd11036d5157c596f02e77d3b411829a8491
Author: Dan Williams <dcbw redhat com>
Date: Thu Feb 28 16:07:37 2013 +0100
applet: fix crash when using MM1 in mobile broadband PIN dialog
libsecret returns an empty list, so don't try to dereference that
list. gnome-keyring had different API so this only showed up
with the libsecret port.
src/applet-device-broadband.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/applet-device-broadband.c b/src/applet-device-broadband.c
index 7f0e539..e021278 100644
--- a/src/applet-device-broadband.c
+++ b/src/applet-device-broadband.c
@@ -402,8 +402,9 @@ keyring_pin_check_cb (GObject *source,
}
if (pin == NULL) {
- /* Fall back to the first result's PIN */
- pin = secret_item_get_secret (list->data);
+ /* Fall back to the first result's PIN if we have one */
+ if (list)
+ pin = secret_item_get_secret (list->data);
if (pin == NULL) {
unlock_dialog_new (info->device, info);
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]