[gtksourceview] CompletionModel: rename three functions
- From: SÃbastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtksourceview] CompletionModel: rename three functions
- Date: Thu, 3 Jan 2013 10:24:22 +0000 (UTC)
commit febb0f89ade19e5c2cf330ffc991ded1170f2460
Author: SÃbastien Wilmet <swilmet gnome org>
Date: Wed Jan 2 21:45:15 2013 +0100
CompletionModel: rename three functions
I remember that when reading the code the first time it was difficult to
understand the purpose of those functions. Since the API is private,
there is no renaming problems.
gtksourceview/gtksourcecompletion.c | 14 +++++++-------
gtksourceview/gtksourcecompletionmodel.c | 14 +++++++-------
gtksourceview/gtksourcecompletionmodel.h | 6 +++---
3 files changed, 17 insertions(+), 17 deletions(-)
---
diff --git a/gtksourceview/gtksourcecompletion.c b/gtksourceview/gtksourcecompletion.c
index 303685c..e8c13a5 100644
--- a/gtksourceview/gtksourcecompletion.c
+++ b/gtksourceview/gtksourcecompletion.c
@@ -3179,8 +3179,8 @@ update_completion (GtkSourceCompletion *completion,
completion->priv->select_on_show &&
(!get_selected_proposal (completion, NULL, NULL, NULL) || completion->priv->select_first);
- gtk_source_completion_model_begin (completion->priv->model_proposals,
- completion->priv->active_providers);
+ gtk_source_completion_model_begin_populate (completion->priv->model_proposals,
+ completion->priv->active_providers);
for (item = providers; item != NULL; item = g_list_next (item))
{
@@ -3253,15 +3253,15 @@ _gtk_source_completion_add_proposals (GtkSourceCompletion *completion,
item = g_list_find (completion->priv->running_providers, provider);
g_return_if_fail (item != NULL);
- gtk_source_completion_model_append (completion->priv->model_proposals,
- provider,
- proposals);
+ gtk_source_completion_model_add_proposals (completion->priv->model_proposals,
+ provider,
+ proposals);
if (finished)
{
/* Let the model know this provider is done */
- gtk_source_completion_model_end (completion->priv->model_proposals,
- provider);
+ gtk_source_completion_model_end_populate (completion->priv->model_proposals,
+ provider);
/* Remove provider from list of running providers */
completion->priv->running_providers =
diff --git a/gtksourceview/gtksourcecompletionmodel.c b/gtksourceview/gtksourcecompletionmodel.c
index 733c6b2..09176f3 100644
--- a/gtksourceview/gtksourcecompletionmodel.c
+++ b/gtksourceview/gtksourcecompletionmodel.c
@@ -619,8 +619,8 @@ on_proposal_changed (GtkSourceCompletionProposal *proposal,
}
void
-gtk_source_completion_model_begin (GtkSourceCompletionModel *model,
- GList *providers)
+gtk_source_completion_model_begin_populate (GtkSourceCompletionModel *model,
+ GList *providers)
{
g_return_if_fail (GTK_SOURCE_IS_COMPLETION_MODEL (model));
@@ -1183,9 +1183,9 @@ add_provider_info (GtkSourceCompletionModel *model,
}
void
-gtk_source_completion_model_append (GtkSourceCompletionModel *model,
- GtkSourceCompletionProvider *provider,
- GList *proposals)
+gtk_source_completion_model_add_proposals (GtkSourceCompletionModel *model,
+ GtkSourceCompletionProvider *provider,
+ GList *proposals)
{
GList *item;
ProviderInfo *info;
@@ -1281,8 +1281,8 @@ gtk_source_completion_model_append (GtkSourceCompletionModel *model,
}
void
-gtk_source_completion_model_end (GtkSourceCompletionModel *model,
- GtkSourceCompletionProvider *provider)
+gtk_source_completion_model_end_populate (GtkSourceCompletionModel *model,
+ GtkSourceCompletionProvider *provider)
{
/* Remove unmarked proposals, returns TRUE if there are any proposals
* left for 'provider'. If so, we add 'provider' to the list of
diff --git a/gtksourceview/gtksourcecompletionmodel.h b/gtksourceview/gtksourcecompletionmodel.h
index 333cbba..ef3b66d 100644
--- a/gtksourceview/gtksourcecompletionmodel.h
+++ b/gtksourceview/gtksourcecompletionmodel.h
@@ -71,16 +71,16 @@ GtkSourceCompletionModel *
gtk_source_completion_model_new (void);
G_GNUC_INTERNAL
-void gtk_source_completion_model_begin (GtkSourceCompletionModel *model,
+void gtk_source_completion_model_begin_populate (GtkSourceCompletionModel *model,
GList *providers);
G_GNUC_INTERNAL
-void gtk_source_completion_model_append (GtkSourceCompletionModel *model,
+void gtk_source_completion_model_add_proposals (GtkSourceCompletionModel *model,
GtkSourceCompletionProvider *provider,
GList *proposals);
G_GNUC_INTERNAL
-void gtk_source_completion_model_end (GtkSourceCompletionModel *model,
+void gtk_source_completion_model_end_populate (GtkSourceCompletionModel *model,
GtkSourceCompletionProvider *provider);
G_GNUC_INTERNAL
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]