[banshee] Lastfm: remove useless (and unused) automatic properties in LastfmRequest
- From: AndrÃs Aragoneses <aaragoneses src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee] Lastfm: remove useless (and unused) automatic properties in LastfmRequest
- Date: Fri, 18 Jan 2013 21:31:50 +0000 (UTC)
commit 0e3868c2d8730ec00deb59a20e9499fab094f872
Author: Andres G. Aragoneses <knocte gmail com>
Date: Fri Jan 18 21:31:06 2013 +0000
Lastfm: remove useless (and unused) automatic properties in LastfmRequest
Someone really failed at adding properties here because:
- They don't wrap the fields they are meant to wrap.
- Therefore, they are never assigned any value.
- They are never used, internally or externally.
- If they were wrapping any value, their public setter would make the
object a bit more mutable, which is bad.
All in all, I'm removing them. I could have removed the fields instead
and start using these, but if there's external code using them, what's
the use case really?
No change of behaviour in this commit.
src/Libraries/Lastfm/Lastfm/LastfmRequest.cs | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/src/Libraries/Lastfm/Lastfm/LastfmRequest.cs b/src/Libraries/Lastfm/Lastfm/LastfmRequest.cs
index 4b241af..e18ad0d 100644
--- a/src/Libraries/Lastfm/Lastfm/LastfmRequest.cs
+++ b/src/Libraries/Lastfm/Lastfm/LastfmRequest.cs
@@ -76,15 +76,10 @@ namespace Lastfm
}
private string method;
- public string Method { get; set; }
-
private RequestType request_type;
- public RequestType RequestType { get; set; }
-
private ResponseFormat response_format;
- public ResponseFormat ResponseFormat { get; set; }
public void AddParameter (string param_name, string param_value)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]