[gnome-shell] Notification: fix regression in notification image handling
- From: Giovanni Campagna <gcampagna src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] Notification: fix regression in notification image handling
- Date: Sat, 19 Jan 2013 18:41:42 +0000 (UTC)
commit 45fde4888e2d60fe648a0d35992f70701a94ea1a
Author: Giovanni Campagna <gcampagna src gnome org>
Date: Sat Jan 19 18:52:15 2013 +0100
Notification: fix regression in notification image handling
We must set the image after calling .update(), because we're passing
clear: true and thus we're removing the image too.
Also, we need to specify an explicit icon size, or St.Icon will use
the default (48px)
https://bugzilla.gnome.org/show_bug.cgi?id=692091
js/ui/notificationDaemon.js | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/js/ui/notificationDaemon.js b/js/ui/notificationDaemon.js
index f23b268..fa1d715 100644
--- a/js/ui/notificationDaemon.js
+++ b/js/ui/notificationDaemon.js
@@ -395,17 +395,17 @@ const NotificationDaemon = new Lang.Class({
// one of 'image-data' or 'image-path' are specified, we show both an icon and
// a large image.
if (gicon && gimage)
- image = new St.Icon({ gicon: gimage });
+ image = new St.Icon({ gicon: gimage,
+ icon_size: notification.IMAGE_SIZE });
else if (!gicon && gimage)
gicon = gimage;
else if (!gicon)
gicon = this._fallbackIconForNotificationData(hints);
- notification.setImage(image);
-
notification.update(summary, body, { gicon: gicon,
bannerMarkup: true,
clear: true });
+ notification.setImage(image);
if (actions.length) {
notification.setUseActionIcons(hints['action-icons'] == true);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]