[cogl] This reverts the first hunk from Jerome's last patch
- From: Robert Bragg <rbragg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [cogl] This reverts the first hunk from Jerome's last patch
- Date: Thu, 31 Jan 2013 21:11:09 +0000 (UTC)
commit b19fcc1869275826e952925af922125daf8a48de
Author: Robert Bragg <robert linux intel com>
Date: Thu Jan 31 13:09:54 2013 +0000
This reverts the first hunk from Jerome's last patch
The first hunk from commit 93b7b4c850dd928bf21ee168a95641a8d631f713
turned out to be redundant because GLX guarantees that configs returned
by glXChooseFBConfig should be sorted with non msaa configs coming
first. The second hunk is required since we use glXGetFBConfigs in that
case which doesn't sort the configs.
I had meant to drop this part of the patch before landing it but forgot.
Reviewed-by: Neil Roberts <neil linux intel com>
cogl/winsys/cogl-winsys-glx.c | 19 ++++++-------------
1 files changed, 6 insertions(+), 13 deletions(-)
---
diff --git a/cogl/winsys/cogl-winsys-glx.c b/cogl/winsys/cogl-winsys-glx.c
index 6015196..8519e5f 100644
--- a/cogl/winsys/cogl-winsys-glx.c
+++ b/cogl/winsys/cogl-winsys-glx.c
@@ -768,20 +768,13 @@ glx_attributes_from_framebuffer_config (CoglDisplay *display,
attributes[i++] = GLX_STENCIL_SIZE;
attributes[i++] = config->need_stencil ? 1: GLX_DONT_CARE;
- if (glx_renderer->glx_major == 1 && glx_renderer->glx_minor >= 4)
- {
- if (config->samples_per_pixel)
- {
- attributes[i++] = GLX_SAMPLE_BUFFERS;
- attributes[i++] = 1;
- attributes[i++] = GLX_SAMPLES;
- attributes[i++] = config->samples_per_pixel;
- }
- else
- {
- attributes[i++] = GLX_SAMPLE_BUFFERS;
- attributes[i++] = 0;
- }
+ if (glx_renderer->glx_major == 1 && glx_renderer->glx_minor >= 4 &&
+ config->samples_per_pixel)
+ {
+ attributes[i++] = GLX_SAMPLE_BUFFERS;
+ attributes[i++] = 1;
+ attributes[i++] = GLX_SAMPLES;
+ attributes[i++] = config->samples_per_pixel;
}
attributes[i++] = None;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]