[ostree] main: Drop log builtin
- From: Colin Walters <walters src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [ostree] main: Drop log builtin
- Date: Tue, 23 Jul 2013 22:42:34 +0000 (UTC)
commit 3b9da094d8537777f2ac1d26b127818310568cf9
Author: Colin Walters <walters verbum org>
Date: Tue Jul 23 18:16:54 2013 -0400
main: Drop log builtin
We may revive this later, but commits in their current form aren't
very useful for humans to read, so it doesn't make sense to have a
tool to show a history of useless stuff.
More interesting things are diffs between commits, object statistics,
etc.
Makefile-ostree.am | 1 -
Makefile-tests.am | 1 -
src/libotutil/ot-unix-utils.c | 40 -----------
src/libotutil/ot-unix-utils.h | 2 -
src/ostree/main.c | 1 -
src/ostree/ot-builtin-log.c | 147 -----------------------------------------
src/ostree/ot-builtins.h | 1 -
tests/test-log.sh | 30 --------
8 files changed, 0 insertions(+), 223 deletions(-)
---
diff --git a/Makefile-ostree.am b/Makefile-ostree.am
index 949641e..ee49c38 100644
--- a/Makefile-ostree.am
+++ b/Makefile-ostree.am
@@ -31,7 +31,6 @@ ostree_SOURCES = src/ostree/main.c \
src/ostree/ot-builtin-fsck.c \
src/ostree/ot-builtin-init.c \
src/ostree/ot-builtin-pull-local.c \
- src/ostree/ot-builtin-log.c \
src/ostree/ot-builtin-ls.c \
src/ostree/ot-builtin-prune.c \
src/ostree/ot-builtin-refs.c \
diff --git a/Makefile-tests.am b/Makefile-tests.am
index 19764e6..c7d9e54 100644
--- a/Makefile-tests.am
+++ b/Makefile-tests.am
@@ -23,7 +23,6 @@ insttestdir=$(pkglibexecdir)/installed-tests
testfiles = test-basic \
test-archive \
test-archivez \
- test-log \
test-remote-add \
test-corruption \
test-libarchive \
diff --git a/src/libotutil/ot-unix-utils.c b/src/libotutil/ot-unix-utils.c
index 8cb1992..2933d64 100644
--- a/src/libotutil/ot-unix-utils.c
+++ b/src/libotutil/ot-unix-utils.c
@@ -37,46 +37,6 @@
#include <dirent.h>
gboolean
-ot_util_spawn_pager (GOutputStream **out_stream,
- GError **error)
-{
- gboolean ret = FALSE;
- const char *pager;
- char *argv[2];
- int stdin_fd;
- pid_t pid;
- gs_free GOutputStream *ret_stream = NULL;
-
- if (!isatty (1))
- {
- ret_stream = (GOutputStream*)g_unix_output_stream_new (1, TRUE);
- }
- else
- {
- pager = g_getenv ("GIT_PAGER");
- if (pager == NULL)
- pager = "less";
-
- argv[0] = (char*)pager;
- argv[1] = NULL;
-
- if (!g_spawn_async_with_pipes (NULL, argv, NULL, G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD,
- NULL, NULL, &pid, &stdin_fd, NULL, NULL, error))
- {
- g_prefix_error (error, "%s", "Failed to spawn pager: ");
- goto out;
- }
-
- ret_stream = (GOutputStream*)g_unix_output_stream_new (stdin_fd, TRUE);
- }
-
- ot_transfer_out_value(out_stream, &ret_stream);
- ret = TRUE;
- out:
- return ret;
-}
-
-gboolean
ot_util_filename_validate (const char *name,
GError **error)
{
diff --git a/src/libotutil/ot-unix-utils.h b/src/libotutil/ot-unix-utils.h
index ed15379..aba997f 100644
--- a/src/libotutil/ot-unix-utils.h
+++ b/src/libotutil/ot-unix-utils.h
@@ -36,8 +36,6 @@
G_BEGIN_DECLS
-gboolean ot_util_spawn_pager (GOutputStream **out_stream, GError **error);
-
void ot_util_fatal_literal (const char *msg) G_GNUC_NORETURN;
void ot_util_fatal_gerror (GError *error) G_GNUC_NORETURN;
diff --git a/src/ostree/main.c b/src/ostree/main.c
index b20cdbb..580fc8e 100644
--- a/src/ostree/main.c
+++ b/src/ostree/main.c
@@ -40,7 +40,6 @@ static OstreeCommand commands[] = {
{ "diff", ostree_builtin_diff, 0 },
{ "fsck", ostree_builtin_fsck, 0 },
{ "init", ostree_builtin_init, 0 },
- { "log", ostree_builtin_log, 0 },
{ "ls", ostree_builtin_ls, 0 },
{ "refs", ostree_builtin_refs, 0 },
{ "prune", ostree_builtin_prune, 0 },
diff --git a/src/ostree/ot-builtins.h b/src/ostree/ot-builtins.h
index 777a5e7..358ceea 100644
--- a/src/ostree/ot-builtins.h
+++ b/src/ostree/ot-builtins.h
@@ -36,7 +36,6 @@ gboolean ostree_builtin_diff (int argc, char **argv, GFile *repo_path, GCancella
gboolean ostree_builtin_init (int argc, char **argv, GFile *repo_path, GCancellable *cancellable, GError
**error);
gboolean ostree_builtin_pull (int argc, char **argv, GFile *repo_path, GCancellable *cancellable, GError
**error);
gboolean ostree_builtin_pull_local (int argc, char **argv, GFile *repo_path, GCancellable *cancellable,
GError **error);
-gboolean ostree_builtin_log (int argc, char **argv, GFile *repo_path, GCancellable *cancellable, GError
**error);
gboolean ostree_builtin_ls (int argc, char **argv, GFile *repo_path, GCancellable *cancellable, GError
**error);
gboolean ostree_builtin_prune (int argc, char **argv, GFile *repo_path, GCancellable *cancellable, GError
**error);
gboolean ostree_builtin_refs (int argc, char **argv, GFile *repo_path, GCancellable *cancellable, GError
**error);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]